chore: Rebase on master #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: NativeScript 4.0 integration Angular application is started with `application.run()` which means the the root view of the app will be the root view of the `AppComponent`. Previous behavior: Anagular application was started with `application.start()` - this aways creates a root `Frame`. The platfrom bootstrap was always creating the inital `Page` and loading the `AppComponent` inside. The `<page-router-outlet>` will create a Frame as a native element and will create a page for each component activated in it (including the inital page). * feat: Introduce FrameService for working with frame * test: TabView with multiple outlets project * feat(router): Implemented pageTransitionDuration for NSRouterLInks + improved relative url handling * test: Tests for tests with page outlet and navigation in multiple tabs * fix-next(dialogs): integrate showModal method with changes in 4.0 Rename RootView class to AppHostView class. Expose ngAppRoot property of AppHostView class. Add modal-nested-test example. * chore: tslint errors * fix-next(dialogs): showModal dialog of selector template as root Extend AppHostView class to overwrite the `content` property of ContentView. * test(ng-sample): add modal router outlet example * test(ng-sample): add modal page router outlet example * chore: a tslint error * feat(router): rework to support history by outlet * refactor(dialogs): remove page wrapper * chore(e2e-modal): update modal-navigation-ng app to display miodal view * fix-next(dialogs): handle close modal Sanitize router states and cache when closing modal view * chore(app-host-view): remove unnecessary extractContentFromHost method * test(location): add location strategy tests * chore(tslint): fix errors * chire(modal): ensure close modal called once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on master and fixed a couple modal dialog tests after