Skip to content

UnbufferedSerial: Replace DirectSerial, RawSerial classes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

hugueskamba
Copy link
Owner

@hugueskamba hugueskamba commented Oct 18, 2019

Description

Remove DirectSerial and deprecate RawSerial. Instead
Promote UnbufferedSerial as it provides unbuffered I/O
implementing features from DirectSerial and RawSerial.
It adds FileHandle features to RawSerial and add
add SerialBase features to DirectSerial.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch from 54d02f9 to 9434ea5 Compare October 21, 2019 12:22
@hugueskamba hugueskamba changed the title UnbufferedSerial: Replace DirectSerial, RawSerial and Serial classes UnbufferedSerial: Replace DirectSerial, RawSerial classes Oct 21, 2019
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch from 9434ea5 to 2a49f0f Compare October 21, 2019 12:24
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch 2 times, most recently from 466ea44 to 310a7cd Compare November 13, 2019 08:41
@hugueskamba
Copy link
Owner Author

@evedon Please review 310a7cd

@evedon
Copy link
Collaborator

evedon commented Nov 19, 2019

I find confusing that the serial test is mixed up with the greentea test infrastructure. Ideally, the serial test on the target side should not need to know about the details of the greentea protocol. But we need to share the serial line between the greentea test infrastructure i.e. the “control path” and the actual test i.e. “the data path”. Unfortunately there is no simple way (I believe) to allow the host test to send/receive raw data; only the send_kv and parse_kv functions are provided.
So I am accepting that the test needs to use the greentea protocol. I’d like that we limit the dependency on the protocol to the minimum and more importantly that we avoid code duplication.
I will propose some suggestions in the PR review.

@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch from 310a7cd to dd9ce70 Compare November 22, 2019 11:47
Remove DirectSerial and deprecate RawSerial. Instead
Promote UnbufferedSerial as it provides unbuffered I/O
implementing features from DirectSerial and RawSerial.
It adds FileHandle features to RawSerial and add
add SerialBase features to DirectSerial.
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch from dd9ce70 to 42e4f5e Compare November 22, 2019 11:58
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch 6 times, most recently from 877af95 to 0e333fd Compare November 27, 2019 10:29
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch from 0e333fd to dd695f1 Compare November 27, 2019 11:41
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-serial-class branch from dd695f1 to 80486ca Compare November 27, 2019 14:20
@hugueskamba
Copy link
Owner Author

Raising a PR upstream as this was approved.

hugueskamba pushed a commit that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants