-
Notifications
You must be signed in to change notification settings - Fork 0
UnbufferedSerial: Replace DirectSerial, RawSerial classes #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54d02f9
to
9434ea5
Compare
9434ea5
to
2a49f0f
Compare
466ea44
to
310a7cd
Compare
I find confusing that the serial test is mixed up with the greentea test infrastructure. Ideally, the serial test on the target side should not need to know about the details of the greentea protocol. But we need to share the serial line between the greentea test infrastructure i.e. the “control path” and the actual test i.e. “the data path”. Unfortunately there is no simple way (I believe) to allow the host test to send/receive raw data; only the send_kv and parse_kv functions are provided. |
TESTS/mbed_drivers/unbuffered_Serial/gt_unbuffered_serial_test_env.cpp
Outdated
Show resolved
Hide resolved
TESTS/mbed_drivers/unbuffered_Serial/gt_unbuffered_serial_test_env.cpp
Outdated
Show resolved
Hide resolved
TESTS/mbed_drivers/unbuffered_Serial/gt_unbuffered_serial_test_env.cpp
Outdated
Show resolved
Hide resolved
310a7cd
to
dd9ce70
Compare
Remove DirectSerial and deprecate RawSerial. Instead Promote UnbufferedSerial as it provides unbuffered I/O implementing features from DirectSerial and RawSerial. It adds FileHandle features to RawSerial and add add SerialBase features to DirectSerial.
dd9ce70
to
42e4f5e
Compare
877af95
to
0e333fd
Compare
0e333fd
to
dd695f1
Compare
dd695f1
to
80486ca
Compare
Raising a PR upstream as this was approved. |
Description
Remove
DirectSerial
and deprecateRawSerial
. InsteadPromote
UnbufferedSerial
as it provides unbuffered I/Oimplementing features from
DirectSerial
andRawSerial
.It adds
FileHandle
features toRawSerial
and addadd
SerialBase
features toDirectSerial
.Pull request type
Reviewers
Release Notes