Skip to content

Update reqs to include min gather_for_metrics Accelerate version #20242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

muellerzr
Copy link
Contributor

@muellerzr muellerzr commented Nov 15, 2022

What does this PR do?

Update all the PyTorch examples using accelerate and gather_for_metrics to include a minimum accelerate version of 0.12.0 since this introduced gather_for_metrics

Related to huggingface/accelerate#854

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

@muellerzr muellerzr added the Examples Which is related to examples in general label Nov 15, 2022
@muellerzr muellerzr requested a review from sgugger November 15, 2022 17:40
@HuggingFaceDocBuilder
Copy link

HuggingFaceDocBuilder commented Nov 15, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr merged commit 822ae69 into main Nov 15, 2022
@muellerzr muellerzr deleted the update-example-reqs branch November 15, 2022 18:28
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
…gingface#20242)

* Update reqs to include min gather_for_metrics Accelerate version

* Other reqs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Examples Which is related to examples in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants