Skip to content

Update billing.mdx #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Update billing.mdx #422

merged 2 commits into from
Aug 21, 2023

Conversation

marcusrein
Copy link
Member

Added two videos on adding GRT using a crypto wallet and multisig.

Added two videos on adding GRT.
@marcusrein marcusrein requested a review from a team as a code owner June 14, 2023 21:35
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/de/arbitrum/l2-transfer-tools-guide 11.62 KB 673.57 KB 192.45% (+/- <0.01%)
/ha/release-notes/assemblyscript-migration-guide 10.86 KB 672.81 KB 192.23% (+/- <0.01%)
/hi/arbitrum/l2-transfer-tools-guide 14.19 KB 676.14 KB 193.18% (+/- <0.01%)
/mr/arbitrum/l2-transfer-tools-guide 13.59 KB 675.54 KB 193.01% (+/- <0.01%)
/ur/arbitrum/l2-transfer-tools-guide 13.38 KB 675.33 KB 192.95% (+/- <0.01%)
/vi/arbitrum/l2-transfer-tools-guide 11.62 KB 673.57 KB 192.45% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@@ -39,6 +39,8 @@ While The Graph protocol operates on Ethereum Mainnet, [the billing contract](ht

> This section is written assuming you already have GRT in your crypto wallet, and you're on Ethereum mainnet. If you don't have GRT, you can learn how to get GRT [here](#getting-grt).

For a video walkthrough of adding GRT to your billing balance using a crypto wallet, watch this [video](https://youtu.be/4Bw2sh0FxCg).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but I feel like the word "this" should be included in the link:

Suggested change
For a video walkthrough of adding GRT to your billing balance using a crypto wallet, watch this [video](https://youtu.be/4Bw2sh0FxCg).
For a video walkthrough of adding GRT to your billing balance using a crypto wallet, watch [this video](https://youtu.be/4Bw2sh0FxCg).

@@ -71,6 +73,8 @@ While The Graph protocol operates on Ethereum Mainnet, [the billing contract](ht

### Adding GRT using a multisig wallet

For a video walkthrough of adding GRT to your billing balance using a multisig wallet, watch this [video](https://youtu.be/eCgxp1Rag_0).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For a video walkthrough of adding GRT to your billing balance using a multisig wallet, watch this [video](https://youtu.be/eCgxp1Rag_0).
For a video walkthrough of adding GRT to your billing balance using a multisig wallet, watch [this video](https://youtu.be/eCgxp1Rag_0).

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left two nitpicky comments.

One more thing: maybe you didn't know, but the docs support YouTube embeds with the <VideoEmbed> component. There's an example on this page (line 214).

@marcusrein marcusrein merged commit fcf0e9c into main Aug 21, 2023
@marcusrein marcusrein deleted the marcusrein-patch-4 branch August 21, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants