Skip to content

Hide locale switcher on /en/substreams pages #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

benface
Copy link
Contributor

@benface benface commented Apr 28, 2023

Targeting the substreams branch (PR #346). This is a workaround until the substreams docs are translated somehow (probably through Crowdin too, but set up in the remote repo).

@benface benface requested a review from a team as a code owner April 28, 2023 04:03
@github-actions
Copy link

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 591.49 KB (🟡 +34 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Comment on lines +50 to +54
{
source: '/en/substreams/',
destination: '/en/substreams/README/',
permanent: false,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so that switching from another language's /substreams page to English works.

@benface benface merged commit deb1635 into substreams Apr 28, 2023
@benface benface deleted the benface/hide-locale-switcher-on-substreams branch April 28, 2023 15:12
saihaj pushed a commit that referenced this pull request May 2, 2023
* remote substreams docs

* update next.js/nextra

* fix

* pnpm i

* fix lint

* Hide locale switcher on `/en/substreams` pages (#361)

* Hide locale switcher on `/en/substreams` pages

* Trailing slashes are important, apparently

---------

Co-authored-by: Benoît Rouleau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants