Add Edit Page link #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenadjaja
reviewed
Jan 11, 2022
| '14px', | ||
| '12px', | ||
| '10px', | ||
| '96px' = '96px', |
There was a problem hiding this comment.
Lol why do we need this? '96px' = '96px'
There was a problem hiding this comment.
The first 96px is the "name" of the token that we refer to (could also be S/M/L etc. but Erika decided that there were too many of them and didn't want names like XXXXL), while the second 96px is the value that is actually used in the CSS. Yes, they are the same, but they could eventually not be. For instance, if we decided to use rem units for accessibility reasons, we could change this to '96px' = '6rem'. :)
nenadjaja
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.