Skip to content

Commit 2281290

Browse files
authored
fix(deps): Require proto-plus >=1.20.5 (#593)
* fix(deps): Require proto-plus >=1.20.5 In proto-plus 1.20.5, the protobuf dependency is pinned to <4.0.0dev Fix #592
1 parent 843c278 commit 2281290

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

google/cloud/firestore_v1/_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1209,7 +1209,7 @@ def deserialize_bundle(
12091209
bundle_element: BundleElement = BundleElement.from_json(json.dumps(data)) # type: ignore
12101210
except AttributeError as e:
12111211
# Some bad serialization formats cannot be universally deserialized.
1212-
if e.args[0] == "'dict' object has no attribute 'find'":
1212+
if e.args[0] == "'dict' object has no attribute 'find'": # pragma: NO COVER
12131213
raise ValueError(
12141214
"Invalid serialization of datetimes. "
12151215
"Cannot deserialize Bundles created from the NodeJS SDK."

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
# Until this issue is closed
3434
# https://github.com/googleapis/google-cloud-python/issues/10566
3535
"google-cloud-core >= 1.4.1, <3.0.0dev",
36-
"proto-plus >= 1.10.0",
36+
"proto-plus >= 1.20.5, <2.0.0dev",
3737
]
3838
extras = {}
3939

testing/constraints-3.6.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
# Then this file should have foo==1.14.0
88
google-api-core==1.31.5
99
google-cloud-core==1.4.1
10-
proto-plus==1.10.0
11-
protobuf==3.12.0 # transitive from `google-api-core`
10+
proto-plus==1.20.5
11+
protobuf==3.19.0 # transitive from `google-api-core`

0 commit comments

Comments
 (0)