Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/vscode-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.41.3
Choose a base ref
...
head repository: golang/vscode-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.41.4
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Apr 23, 2024

  1. Revert "extension/src/welcome: fix 'go.showWelcome' setting interpret… 

    …ation"

This reverts commit f8173bc.

Reason: broke the welcome page suppression based on isInCloudIDE
Change-Id: If042f5269754f7dd6cb4c1b2473979d5e11247b3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/581117
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
kokoro-CI: kokoro <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
    @hyangah
    hyangah committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cfc795c View commit details
    Browse the repository at this point in the history

  2. extension/src/welcome: readd the fix for go.showWelcome handling 

    The original fix for #3319 also included
a minor refactoring attempt - centralize welcome page show logic
in shouldShowGoWelcomePage. But that unfortunately introduced
a new bug, i.e., failed to apply the Web-based IDE exclusion rule
correctly.

Reverted the previous change to remove the refactoring.
And, this change adds the specific fix to address the bug reported
in #3319.

Test coverage would be nice, but it is tricky without
major refactoring or complicating test logic to stub or
inject dependencies.

Renamed shouldShowGoWelcomePage to make it clear that
this is to decide whether we have news to show purely
based on the extension's version.

For #3319.

Change-Id: Ia4915e0201e73d136b3efcec7c0cf4f5a5e4559f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/581118
kokoro-CI: kokoro <[email protected]>
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
    @hyangah
    hyangah committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d1cde8c View commit details
    Browse the repository at this point in the history

  3. extension/CHANGELOG.md: add the entry for v0.41.4 

    Change-Id: Id349296ce5bc0504aa22183bc2826b6558c87f07
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/581119
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
kokoro-CI: kokoro <[email protected]>
    @hyangah
    hyangah committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ea9ff87 View commit details
    Browse the repository at this point in the history

  4. [release] prepare v0.41.4 release 

    ea9ff87 extension/CHANGELOG.md: add the entry for v0.41.4
d1cde8c extension/src/welcome: readd the fix for go.showWelcome handling
cfc795c Revert "extension/src/welcome: fix 'go.showWelcome' setting interpretation"

Change-Id: Iebf964dacaaa47e02c7219aafc2d7c8e3d7bdfec
    @hyangah
    hyangah committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    07815f3 View commit details
    Browse the repository at this point in the history

  5. [release] extension/package.json: set version to 0.41.4 

    Change-Id: I8ba98d4a4c9ff81335dfda6cf0f9b155c82ff109
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/581178
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
kokoro-CI: kokoro <[email protected]>
Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
    @hyangah @gopherbot
    hyangah authored and gopherbot committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    db1036f View commit details
    Browse the repository at this point in the history
Loading