-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/mobile: Remove gomobile dependency on gobind binary #34708
Comments
CC @hyangah I would like to keep separate binaries. In the context of Go modules, |
Commands |
Sorry if I'm wrong, but some of the Go tools you mentioned are separated binaries. |
Here is example https://github.com/golang/go/blob/master/src/cmd/go/main.go#L43 how different tools are used with go command. In the end they can be both as separate binaries and reused for main binary command. |
/cc @hyangah @eliasnaur |
ping @hyangah and @eliasnaur again. Any thoughts? |
/cc @steeve |
SGTM. |
SGTM, as long as the functionality is kept (we use it in https://github.com/znly/rules_gomobile). |
SGTM eventually, but not sure who will work on and who will maintain. IIRC, gomobile originally invoked the bind library. But as it became more complex and major users of go mobile binding move out of gomobile and the development focus was moved more on gobind itself, gomobile was changed to simply invoke gobind for easier code maintenance. |
I assume this proposal is about merging the binaries, not the code. The bind code stays in a separate package. |
ping @hyangah |
Once we can make the library (probably internal) and succeed to make
|
Currently
gomobile bind
internally depends on gobind command. This is not user friendly and seems unnecessary too complex as user need to build both binaries. I propose to remove cmd/gobind so there is only one binary. As there is difference whatgomobile bind
andgobind
does we can pass extra flag togomobile bind -gen_only
to only generate bindings without compiling to final project.If cmd/gobind is still needed (not sure why) we can extra all reusable logic to separate package so it can be used directly in both cmd/gomobile and cmd/gobind.
If this make sense I can work on it.
/cc @hajimehoshi @eliasnaur
The text was updated successfully, but these errors were encountered: