feat(gnofmt): delete trailing whitespaces #4214
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: was working on #4211 and noticed that
make fmt
andmake test.sync
aren't compatible...This change may not be what we want, but I would like to propose it to gather opinions.
I believe that if we do not allow gnofmt to ignore trailing whitespaces, we should still expect this repository to adhere to this rule. Perhaps we could implement a second rule in "make fmt" that calls another binary.
In addition to reviewing my implementation, please share your thoughts.