chore: small fixes #4195
Merged
chore: small fixes #4195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
jaekwon
reviewed
Apr 21, 2025
gnovm/pkg/gnolang/machine.go
Outdated
| if fnSource != nil { | ||
| call.FuncLoc = fnSource.GetLocation() | ||
| } | ||
| calls = append(calls, call) |
There was a problem hiding this comment.
I think the issue you're trying to solve is solved here: https://github.com/gnolang/gno/pull/4192/files#r2052132917
Better to keep the machine simple and tailor the tests to suit it.
jaekwon
reviewed
Apr 21, 2025
| @@ -2017,13 +2021,6 @@ func (m *Machine) peekCallFrame(n int) *Frame { | |||
| // Returns the last defer call frame or nil. | |||
| func (m *Machine) LastDeferCallFrame() *Frame { | |||
| return &m.Frames[len(m.Frames)-1] | |||
There was a problem hiding this comment.
oops this isn't used, should be deleted.
There was a problem hiding this comment.
Do you mean to remove this line and revert the dead code I just deleted below?
There was a problem hiding this comment.
no, we should delete it, it isn't used at all.
jaekwon
approved these changes
Apr 23, 2025
jaekwon
pushed a commit
that referenced
this pull request
May 1, 2025
Failing CI checks decreased from 24 to 5. --------- Signed-off-by: moul <[email protected]>
stefann-01
pushed a commit
to stefann-01/gno
that referenced
this pull request
Jul 14, 2025
Failing CI checks decreased from 24 to 5. --------- Signed-off-by: moul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing CI checks decreased from 24 to 5.