Skip to content

feat(event-attributes): Make Expo Context searchable #90148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Apr 23, 2025

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/rules/conditions/event_attribute.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #90148      +/-   ##
==========================================
- Coverage   87.71%   87.71%   -0.01%     
==========================================
  Files       10247    10249       +2     
  Lines      577561   578495     +934     
  Branches    22715    22715              
==========================================
+ Hits       506601   507420     +819     
- Misses      70517    70632     +115     
  Partials      443      443              

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@krystofwoldrich krystofwoldrich removed the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2025
@krystofwoldrich krystofwoldrich marked this pull request as ready for review April 23, 2025 14:45
@krystofwoldrich krystofwoldrich requested a review from a team as a code owner April 23, 2025 14:45
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tests!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants