Skip to content

feat(nav): Add quota exceeded alert #88037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 7, 2025
Merged

Conversation

isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Mar 26, 2025

This PR implements the new sidebar quota alert. This PR also changes the incident status sidebar item to use the fire icon.

A follow up PR will implement the auto-open behavior when not all prompts have been dismissed.

quota.alert.demo.2.mov

light mode

Screenshot 2025-04-07 at 10 55 48 AM

dark mode

Screenshot 2025-04-07 at 10 55 18 AM

Waiting on https://github.com/getsentry/getsentry/pull/17118

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10086 1 10085 5
View the full list of 1 ❄️ flaky tests
spanEvidence renders and attempts to render the trace preview

Flake rate in main: 17.07% (Passed 34 times, Failed 7 times)

Stack Traces | 11.3s run time
Error: thrown: "Exceeded timeout of 10000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../interfaces/performance/spanEvidence.spec.tsx:20:3
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../interfaces/performance/spanEvidence.spec.tsx:16:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@isabellaenriquez isabellaenriquez marked this pull request as ready for review April 2, 2025 19:34
@isabellaenriquez isabellaenriquez requested a review from a team as a code owner April 2, 2025 19:34
handleRequestSent={() => {}}
/>
<DismissContainer>
<Checkbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense for this to be a button? A checkbox that immediately dismisses doesn't make sense to me

Copy link
Member Author

@isabellaenriquez isabellaenriquez Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes straight from design but definitely something I can ask the team about (ie. if we're hardset on a checkbox)

Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you responding to all my comments!

@isabellaenriquez isabellaenriquez merged commit e8e2370 into master Apr 7, 2025
42 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/quota-alert branch April 7, 2025 21:30
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
This PR implements the new sidebar quota alert. This PR also changes the
incident status sidebar item to use the fire icon.

A follow up PR will implement the auto-open behavior when not all
prompts have been dismissed.





https://github.com/user-attachments/assets/e0790bfe-1b03-4b57-9945-84e640eb8ef9

### light mode
![Screenshot 2025-04-07 at 10 55
48 AM](https://github.com/user-attachments/assets/ae2fdffd-c501-4a54-93a2-a6bc3b37a2d5)

### dark mode
![Screenshot 2025-04-07 at 10 55
18 AM](https://github.com/user-attachments/assets/774507f7-418f-4c1d-b26a-f5209630b0f3)



Waiting on getsentry/getsentry#17118
Christinarlong pushed a commit that referenced this pull request Apr 10, 2025
This PR implements the new sidebar quota alert. This PR also changes the
incident status sidebar item to use the fire icon.

A follow up PR will implement the auto-open behavior when not all
prompts have been dismissed.





https://github.com/user-attachments/assets/e0790bfe-1b03-4b57-9945-84e640eb8ef9

### light mode
![Screenshot 2025-04-07 at 10 55
48 AM](https://github.com/user-attachments/assets/ae2fdffd-c501-4a54-93a2-a6bc3b37a2d5)

### dark mode
![Screenshot 2025-04-07 at 10 55
18 AM](https://github.com/user-attachments/assets/774507f7-418f-4c1d-b26a-f5209630b0f3)



Waiting on getsentry/getsentry#17118
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants