-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(nav): Add quota exceeded alert #88037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
handleRequestSent={() => {}} | ||
/> | ||
<DismissContainer> | ||
<Checkbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense for this to be a button? A checkbox that immediately dismisses doesn't make sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes straight from design but definitely something I can ask the team about (ie. if we're hardset on a checkbox)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thank you responding to all my comments!
This PR implements the new sidebar quota alert. This PR also changes the incident status sidebar item to use the fire icon. A follow up PR will implement the auto-open behavior when not all prompts have been dismissed. https://github.com/user-attachments/assets/e0790bfe-1b03-4b57-9945-84e640eb8ef9 ### light mode  ### dark mode  Waiting on getsentry/getsentry#17118
This PR implements the new sidebar quota alert. This PR also changes the incident status sidebar item to use the fire icon. A follow up PR will implement the auto-open behavior when not all prompts have been dismissed. https://github.com/user-attachments/assets/e0790bfe-1b03-4b57-9945-84e640eb8ef9 ### light mode  ### dark mode  Waiting on getsentry/getsentry#17118
This PR implements the new sidebar quota alert. This PR also changes the incident status sidebar item to use the fire icon.
A follow up PR will implement the auto-open behavior when not all prompts have been dismissed.
quota.alert.demo.2.mov
light mode
dark mode
Waiting on https://github.com/getsentry/getsentry/pull/17118