Skip to content

feat(expo): Auto collect Expo Updates Context #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 24, 2025

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Apr 22, 2025

📢 Type of change

  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR adds Expo Updates Constants https://docs.expo.dev/versions/latest/sdk/updates/#constants as Event Context in event.contexts.expo_updates. This information can be both useful for debugging error and specified fields channel, updateId and runtimeVersion will searchable on the backend for filtering.

Screenshot 2025-04-22 at 16 52 22

⛓️ Part of

💚 How did you test it?

sample app, unit tests tba

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Apr 22, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 259ada7

Copy link
Contributor

github-actions bot commented Apr 22, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 469.00 ms 454.02 ms -14.98 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a0b0298 427.50 ms 428.10 ms 0.60 ms
e73d82f 475.82 ms 506.55 ms 30.73 ms
0eacc98 431.88 ms 454.56 ms 22.68 ms
2de79dc 435.31 ms 416.96 ms -18.35 ms
9282172 486.12 ms 467.70 ms -18.42 ms
a18210a 455.15 ms 530.29 ms 75.15 ms
24cb2a4 451.04 ms 446.07 ms -4.98 ms
700cbf4 425.56 ms 436.26 ms 10.70 ms
5dff5ee 462.32 ms 456.26 ms -6.06 ms
75774ea 454.16 ms 467.80 ms 13.64 ms

App size

Revision Plain With Sentry Diff
a0b0298 17.75 MiB 20.12 MiB 2.37 MiB
e73d82f 17.73 MiB 20.07 MiB 2.33 MiB
0eacc98 17.75 MiB 20.11 MiB 2.37 MiB
2de79dc 17.75 MiB 20.13 MiB 2.38 MiB
9282172 17.74 MiB 20.09 MiB 2.35 MiB
a18210a 17.75 MiB 20.11 MiB 2.36 MiB
24cb2a4 17.75 MiB 20.11 MiB 2.36 MiB
700cbf4 17.73 MiB 20.07 MiB 2.33 MiB
5dff5ee 17.75 MiB 20.11 MiB 2.36 MiB
75774ea 17.74 MiB 20.08 MiB 2.35 MiB

Previous results on branch: kw-add-expo-updates-context

Startup times

Revision Plain With Sentry Diff
bbd3b62 437.55 ms 445.10 ms 7.55 ms
987a346 444.59 ms 471.56 ms 26.97 ms

App size

Revision Plain With Sentry Diff
bbd3b62 17.75 MiB 20.13 MiB 2.38 MiB
987a346 17.75 MiB 20.13 MiB 2.38 MiB

Copy link
Contributor

github-actions bot commented Apr 22, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 380.54 ms 405.84 ms 25.30 ms
Size 7.15 MiB 8.40 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7301787+dirty 462.28 ms 487.34 ms 25.06 ms
00354a7+dirty 426.55 ms 447.33 ms 20.78 ms
1c65324+dirty 381.10 ms 427.26 ms 46.16 ms
42438c2+dirty 652.82 ms 676.21 ms 23.39 ms
0eacc98+dirty 393.31 ms 445.21 ms 51.90 ms
fc150fe+dirty 409.55 ms 407.37 ms -2.18 ms
800171e+dirty 432.15 ms 549.63 ms 117.48 ms
2f9e699+dirty 407.69 ms 398.20 ms -9.49 ms
4161236+dirty 429.89 ms 498.74 ms 68.85 ms
d997097+dirty 404.23 ms 477.09 ms 72.87 ms

App size

Revision Plain With Sentry Diff
7301787+dirty 7.15 MiB 8.40 MiB 1.24 MiB
00354a7+dirty 7.15 MiB 8.40 MiB 1.25 MiB
1c65324+dirty 7.15 MiB 8.22 MiB 1.07 MiB
42438c2+dirty 7.15 MiB 8.40 MiB 1.25 MiB
0eacc98+dirty 7.15 MiB 8.38 MiB 1.23 MiB
fc150fe+dirty 7.15 MiB 8.38 MiB 1.23 MiB
800171e+dirty 7.15 MiB 8.38 MiB 1.23 MiB
2f9e699+dirty 7.15 MiB 8.40 MiB 1.25 MiB
4161236+dirty 7.15 MiB 8.38 MiB 1.23 MiB
d997097+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: kw-add-expo-updates-context

Startup times

Revision Plain With Sentry Diff
987a346+dirty 387.34 ms 392.40 ms 5.06 ms
bbd3b62+dirty 412.69 ms 422.64 ms 9.94 ms

App size

Revision Plain With Sentry Diff
987a346+dirty 7.15 MiB 8.40 MiB 1.25 MiB
bbd3b62+dirty 7.15 MiB 8.40 MiB 1.25 MiB

Copy link
Contributor

github-actions bot commented Apr 22, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.83 ms 1214.79 ms 9.96 ms
Size 2.63 MiB 3.78 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b8ff156+dirty 1236.51 ms 1234.53 ms -1.98 ms
40c35c5+dirty 1211.31 ms 1217.71 ms 6.40 ms
ae7b03d+dirty 1221.19 ms 1224.69 ms 3.50 ms
5fe8312+dirty 1222.06 ms 1220.56 ms -1.51 ms
3f05680+dirty 1229.37 ms 1235.04 ms 5.68 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
34aba08+dirty 1276.78 ms 1308.52 ms 31.74 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
f80e57e+dirty 1217.29 ms 1230.61 ms 13.32 ms
2dc8f22+dirty 1224.88 ms 1212.40 ms -12.47 ms

App size

Revision Plain With Sentry Diff
b8ff156+dirty 2.36 MiB 3.11 MiB 759.80 KiB
40c35c5+dirty 2.63 MiB 3.70 MiB 1.07 MiB
ae7b03d+dirty 2.63 MiB 3.69 MiB 1.05 MiB
5fe8312+dirty 2.63 MiB 3.70 MiB 1.06 MiB
3f05680+dirty 2.63 MiB 3.74 MiB 1.11 MiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
34aba08+dirty 2.36 MiB 2.85 MiB 495.32 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
f80e57e+dirty 2.63 MiB 3.78 MiB 1.14 MiB
2dc8f22+dirty 2.63 MiB 3.69 MiB 1.05 MiB

Previous results on branch: kw-add-expo-updates-context

Startup times

Revision Plain With Sentry Diff
987a346+dirty 1218.94 ms 1218.96 ms 0.02 ms
bbd3b62+dirty 1219.50 ms 1216.65 ms -2.85 ms

App size

Revision Plain With Sentry Diff
987a346+dirty 2.63 MiB 3.78 MiB 1.15 MiB
bbd3b62+dirty 2.63 MiB 3.78 MiB 1.15 MiB

Copy link
Contributor

github-actions bot commented Apr 22, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.69 ms 1216.55 ms -0.14 ms
Size 3.19 MiB 4.35 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b8ff156+dirty 1238.92 ms 1239.57 ms 0.66 ms
40c35c5+dirty 1223.90 ms 1217.19 ms -6.71 ms
ae7b03d+dirty 1223.71 ms 1227.69 ms 3.98 ms
5fe8312+dirty 1235.07 ms 1220.41 ms -14.66 ms
3f05680+dirty 1226.09 ms 1235.67 ms 9.59 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
34aba08+dirty 1268.58 ms 1276.80 ms 8.22 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
f80e57e+dirty 1226.92 ms 1226.82 ms -0.10 ms
2dc8f22+dirty 1215.43 ms 1206.68 ms -8.75 ms

App size

Revision Plain With Sentry Diff
b8ff156+dirty 2.92 MiB 3.67 MiB 772.38 KiB
40c35c5+dirty 3.19 MiB 4.27 MiB 1.08 MiB
ae7b03d+dirty 3.19 MiB 4.25 MiB 1.06 MiB
5fe8312+dirty 3.19 MiB 4.26 MiB 1.08 MiB
3f05680+dirty 3.19 MiB 4.31 MiB 1.12 MiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
34aba08+dirty 2.92 MiB 3.41 MiB 499.03 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
f80e57e+dirty 3.19 MiB 4.34 MiB 1.16 MiB
2dc8f22+dirty 3.19 MiB 4.25 MiB 1.06 MiB

Previous results on branch: kw-add-expo-updates-context

Startup times

Revision Plain With Sentry Diff
987a346+dirty 1228.82 ms 1228.57 ms -0.24 ms
bbd3b62+dirty 1229.37 ms 1233.00 ms 3.63 ms

App size

Revision Plain With Sentry Diff
987a346+dirty 3.19 MiB 4.35 MiB 1.16 MiB
bbd3b62+dirty 3.19 MiB 4.35 MiB 1.16 MiB

krystofwoldrich and others added 3 commits April 24, 2025 11:59
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) April 24, 2025 12:11
@krystofwoldrich krystofwoldrich merged commit 4b49b57 into main Apr 24, 2025
66 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-add-expo-updates-context branch April 24, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants