Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.19.0
Choose a base ref
...
head repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.19.1
Choose a head ref
  • 18 commits
  • 32 files changed
  • 10 contributors

Commits on Nov 21, 2024

  1. Merge branch 'release/2.19.0'

    getsentry-bot committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a7c2d70 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Fix spans for streaming responses in WSGI based frameworks (#3798)

    Fixes spans in streaming responses when using WSGI based frameworks. Only close the transaction once the response was consumed. This way all the spans created during creation of the response will be recorded with the transaction:
    
    - The transaction stays open until all the streaming blocks are sent to the client. (because of this I had to update the tests, to make sure the tests, consume the response, because the Werkzeug test client (used by Flask and Django and our Strawberry tests) will not close the WSGI response)
    - A maximum runtime of 5 minutes for transactions is enforced. (like Javascript does it)
    - When using a generator to generate the streaming response, it uses the correct scopes to have correct parent-child relationship of spans created in the generator.
    
    People having Sentry in a streaming application will:
    - See an increase in their transaction duration to up to 5 minutes
    - Get the correct span tree for streaming responses generated by a generator
    
    Fixes #3736
    antonpirker authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    da20623 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Use new clickhouse gh action (#3826)

    The docker image name of the official Clickhouse docker image changed, so I updated our GH action that starts that docker container and reference the new version here.
    antonpirker authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    7022446 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Configuration menu
    Copy the full SHA
    65b1791 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Fix CI (#3834)

    The latest release of httpx seems to have broken the test clients of some older versions of Litestar, Starlite, Anthropic, Langchain, OpenAI, Starlette.
    
    Pinning httpx for old versions.
    
    Also tweaking what versions to test against.
    sentrivana authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e7130e8 View commit details
    Browse the repository at this point in the history
  2. build(deps): bump codecov/codecov-action from 5.0.2 to 5.0.7 (#3821)

    * build(deps): bump codecov/codecov-action from 5.0.2 to 5.0.7
    
    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.0.2 to 5.0.7.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@v5.0.2...v5.0.7)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    
    * template
    
    ---------
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Ivana Kellyer <[email protected]>
    dependabot[bot] and sentrivana authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c4274a3 View commit details
    Browse the repository at this point in the history
  3. Fix asyncio testing setup (#3832)

    * Fix asyncio testing setup
    
    * default `asyncio_default_fixture_loop_scope` to `function` to get rid
      of deprecation messages
    * Change `test_asyncio.py` event loop scopes to `module` to avoid that
      event loop bleeding into all other tests in the same `session`.
    * Remove explicit `event_loop`s since `pytest-asyncio` takes care of
      those
    * Bump asyncio tests to 3.8 min
    sl0thentr0py authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6bd7e08 View commit details
    Browse the repository at this point in the history
  4. Revert "Fix spans for streaming responses in WSGI based frameworks (#…

    …3798)" (#3836)
    
    This reverts commit da20623. (PR #3798)
    
    Having a timer thread on each request is too much overhead on high volume servers.
    antonpirker authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3d8445c View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Configuration menu
    Copy the full SHA
    dfb84cc View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Improve ray tests (#3846)

    * Make ray tests actually test something and show that actors are not supported
    antonpirker authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    3e43a91 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2024

  1. fix(grpc): Return proper metadata object instead of list in… (#3205)

    * fix(grpc): Return propagate proper metadata object instead of list in client interceptor
    
    Fixes #2509
    
    * fix(grpc): Transform metadata into Metadata object in case it's a tuple
    
    Up until version 1.65.0 of grpcio, the metadata was not guaranteed to
    arrive as the type specified in annotations but could be a tuple.
    To support versions before that we check and transform it here.
    
    * docs(grpc): Add comment about workaround
    
    ---------
    
    Co-authored-by: Anton Pirker <[email protected]>
    Co-authored-by: Daniel Szoke <[email protected]>
    3 people authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    50ad148 View commit details
    Browse the repository at this point in the history
  2. Add missing stack frames (#3673)

    Add a new `init()` option `add_full_stack` (default `False`), when set to `True` it will add all the missing frames from the beginning of the execution to the stack trace sent to Sentry. 
    
    Also adds another option `max_stack_frames` (default `100`) to limit the number of frames sent. The limitation is only enforced when `add_full_stack=True` to not change behavior for existing users. 
    
    Fixes #3646
    antonpirker authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    cda5127 View commit details
    Browse the repository at this point in the history
  3. Script for checking if our instrumented libs are python 3.13 compatib…

    …le (#3425)
    
    A simple script that parses all libraries we test against from our `tox.ini` and then checks PyPI if this library already supports the newest Python version (currently 3.13)
    antonpirker authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    5891717 View commit details
    Browse the repository at this point in the history
  4. fix(django): Fix errors when instrumenting Django cache (#3855)

    I was testing Spotlight with Sentry and realized things started to get slow and crashy. It looks like sometimes `args` is just an empty array on cache's `_instruments_call` causing lots of exceptions being thrown. This patch fixes that with explicit length checks and also adds a note for the missing instrumentation for `get_or_set` method. This might be related to #2122 and #3300.
    BYK authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    31fdcfa View commit details
    Browse the repository at this point in the history
  5. fix(spotlight): Don't give up on Spotlight on 3 errors (#3856)

    Current Spotlight error handling logic gives up sending events to Spotlight after 3 errors. This doesn't make much sense because:
    
    1. Since there is no back off or retry mechanism, even a very brief server hiccup or restart turns off Spotlight reporting
    2. Once this shut off kicks in, there is no way to turn it back on except for a server restart
    
    I added a note for future work for retries and some short buffer.
    BYK authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    5a09770 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7a6d460 View commit details
    Browse the repository at this point in the history
  7. release: 2.19.1

    getsentry-bot committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    c591b64 View commit details
    Browse the repository at this point in the history
  8. Update CHANGELOG.md

    sentrivana authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    231a6a1 View commit details
    Browse the repository at this point in the history
Loading