feat(solidstart)!: No longer export sentrySolidStartVite
#15143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
approved these changes
Jan 23, 2025
lforst
approved these changes
Jan 23, 2025
lforst
reviewed
Jan 23, 2025
docs/migration/v8-to-v9.md
Outdated
| @@ -234,6 +234,10 @@ Sentry.init({ | |||
| - The `addNormalizedRequestDataToEvent` method has been removed. Use `httpRequestToRequestData` instead and put the resulting object directly on `event.request`. | |||
| - A `sampleRand` field on `PropagationContext` is now required. This is relevant if you used `scope.setPropagationContext(...)` | |||
|
|
|||
| ### `@sentry/solidstart` | |||
|
|
|||
| - The `sentrySolidStartVite` plugin is no longer exported. Instead, wrap the SolidStart config with `withSentry` and provide Sentry options as the second parameter. | |||
There was a problem hiding this comment.
If you want to be extra cool, you could add an example code snippet here of how that migration will look. Once we write this migration guide out we are gonna have more of those so we might already get started with that.
|
Also I believe we can remove the changelog entry (?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the default way of setting up the SDK and passing the Sentry options is by wrapping the SolidStart config with
withSentry, the previous method of using thesentrySolidStartViteplugin is no longer supported.