Skip to content

Fixup for failing Beta CI #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fixup for failing Beta CI #2092

merged 2 commits into from
Nov 16, 2023

Conversation

domesticmouse
Copy link
Contributor

Turns out, we shipped a new Flutter beta as well.

Commenting out experimental/varfont_shader_puzzle from beta CI

Everything else is just cleanup.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

parlough
parlough approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup cleanup 🥳

Edit: Looks like you'll need to do some minor cleanup for warnings that 3.2.0 private field promotion triggered.

@domesticmouse domesticmouse changed the title Fixup for failiing Beta CI Fixup for failing Beta CI Nov 16, 2023
@domesticmouse domesticmouse merged commit 0ccc283 into flutter:main Nov 16, 2023
@domesticmouse domesticmouse deleted the fixup-for-failing-beta-CI branch November 16, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domesticmouse @parlough