Skip to content

Pin Chrome version for test-all.yml #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Pin Chrome version for test-all.yml #7260

merged 2 commits into from
Apr 25, 2023

Conversation

hsubox76
Copy link
Contributor

Add Chrome pinning to test-all.yml, as was done for the auth-only tests in #7157. Although this is not a required check, it runs on all PRs and causes noise.

Auth team is working to determine the root cause and see if the tests can be fixed or skipped.

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

⚠️ No Changeset found

Latest commit: 04ff3e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 25, 2023 17:45
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners April 25, 2023 17:45
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2023

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 450e000 into master Apr 25, 2023
@hsubox76 hsubox76 deleted the ch-pin branch April 25, 2023 21:28
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants