enablePersistance in an iOS WebView causes queries to take minutes to resolve.

[KoryNunn]

[REQUIRED] Describe your environment

• Operating System version: iOS (All)
• Browser version: Safari 15.5 (Web View ONLY, eg: cordova)
• Firebase SDK version: 8.10.1
• Firebase Product: firestore

[REQUIRED] Describe the problem

After calling enablePersistence, the next query will not resolve for up to 10 minutes. After it resolves, everything seems to work as normal.

This looks like a regression of: #3120 More likely to be just un unreleased fix, see first comment.

If enablePersistence is not called, everything works as expected.

Steps to reproduce:

1. Call firestore.enablePersistance();
2. Do a .get()

Relevant Code:

N/A

[KoryNunn]

After further testingI'm almost certain the issue is due to the following fix not being released to version 8.X of the sdk:

firebase-js-sdk/packages/firestore/src/local/indexeddb_persistence.ts

Line 980 in 46fe136

if (isSafari() && navigator.appVersion.match(/Version\/1[45]/)) {

If i make that change manually in my node_modules, the app works correctly.

[KoryNunn]

Additionally, WKWebView does not report with an appVersion that includes "Version", at least in Cordova, so this check will continue to fail.

[dconeybe]

Hi @KoryNunn. I noticed that you've reported this issue against v8.10.1. We are no longer making releases of the v8 SDK, except in the case of emergency security vulnerabilities (e.g. https://firebase.google.com/support/release-notes/js#version_8101_-_january_28_2022).

Are you able to reproduce this issue in the latest version of this SDK, which is 9.9.1 at the time of writing?

[KoryNunn]

We cannot trivially update to v9 due to how v9 automatically decideds what environment it is running in. This issue will not exist in v9 because the fix has already been added, it's just not in v8.

If the target environment in v9 could be manually spcified we could upgrate without difficulty, but for now, it's a black box that decideds its running in node/web it's self, in our unit tests, which then don't work.

[dconeybe]

Hi @KoryNunn. If you continue using v8 then there isn't anything I can do to help. Your option would be to maintain your own fork with the required patches. This isn't a great long-term solution, though, because the Firestore world will move on in v9 and leave you behind. But it is definitely an option if you so choose.

Since you're blocked from upgrading to v9, then the best way forward would be to focus on that issue. You mentioned "If the target environment in v9 could be manually spcified we could upgrate without difficulty". Could you elaborate? For example, can you clarify what do you mean by "target environment" and what you would need to "specify"?

[google-oss-bot]

Hey @KoryNunn. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

[KoryNunn]

@dconeybe firebase internally looks for things like window or process on global scope, and decideds that it is running in a browser or node. Our integration tests run in node, using jsdom. We can trick v8 into working, but have not succeeded in tricking v9.

If there was a config option or even seperate module for firebase that was spcific to browser/node, we could just tell it "assume you are in a browser" so that it would in our tests.

This isn't fresh in my mind having not attempted an uprade in a while, I'll see if I can have another look soon to be more specific with the issues we run into.