Upgrade closure-builder and optimize build size. (#1557)

* Upgraded closure-builder (necessary to be able to specify multiple defines).
* Disabled closure debug code (in particular logging) and several legacy
  fallbacks that we don't need.

Author: mikelehen

packages/webchannel-wrapper/package.json

@@ -15,7 +15,7 @@
   },
   "license": "Apache-2.0",
   "devDependencies": {
-    "closure-builder": "2.3.0",
+    "closure-builder": "2.3.4",
     "rollup": "0.57.1",
     "rollup-plugin-commonjs": "9.1.0",
     "rollup-plugin-hypothetical": "2.1.0",

packages/webchannel-wrapper/tools/build.js

@@ -23,6 +23,19 @@ const hypothetical = require('rollup-plugin-hypothetical');
 const glob = closureBuilder.globSupport();
 const { resolve } = require('path');
 
+const closureDefines = [
+  // Avoid unsafe eval() calls (https://github.com/firebase/firebase-js-sdk/issues/798)
+  'goog.json.USE_NATIVE_JSON=true',
+  // Disable debug logging (saves 8780 bytes).
+  'goog.DEBUG=false',
+  // Disable fallbacks for running async code (saves 1472 bytes).
+  'goog.ASSUME_NATIVE_PROMISE=true',
+  // Disables IE8-specific event fallback code (saves 523 bytes).
+  'goog.events.CAPTURE_SIMULATION_MODE=0',
+  // Disable IE-Specific ActiveX fallback for XHRs (saves 524 bytes).
+  'goog.net.XmlHttpDefines.ASSUME_NATIVE_XHR=true'
+];
+
 // commonjs build
 closureBuilder.build({
   name: 'firebase.webchannel.wrapper',
@@ -35,8 +48,7 @@ closureBuilder.build({
         "(function() {%output%}).call(typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : typeof window !== 'undefined' ? window : {})",
       language_out: 'ECMASCRIPT5',
       compilation_level: 'ADVANCED',
-      // Avoid unsafe eval() calls (https://github.com/firebase/firebase-js-sdk/issues/798)
-      define: 'goog.json.USE_NATIVE_JSON=true'
+      define: closureDefines
     }
   }
 });
@@ -51,8 +63,7 @@ closureBuilder.build(
       closure: {
         language_out: 'ECMASCRIPT5',
         compilation_level: 'ADVANCED',
-        // Avoid unsafe eval() calls (https://github.com/firebase/firebase-js-sdk/issues/798)
-        define: 'goog.json.USE_NATIVE_JSON=true'
+        define: closureDefines
       }
     }
   },

yarn.lock

@@ -2946,10 +2946,10 @@ browserify@^14.5.0:
     vm-browserify "~0.0.1"
     xtend "^4.0.0"
 
-browserify@^16.2.2:
-  version "16.2.2"
-  resolved "https://registry.npmjs.org/browserify/-/browserify-16.2.2.tgz#4b1f66ba0e54fa39dbc5aa4be9629142143d91b0"
-  integrity sha512-fMES05wq1Oukts6ksGUU2TMVHHp06LyQt0SIwbXIHm7waSrQmNBZePsU0iM/4f94zbvb/wHma+D1YrdzWYnF/A==
+browserify@^16.2.3:
+  version "16.2.3"
+  resolved "https://registry.npmjs.org/browserify/-/browserify-16.2.3.tgz#7ee6e654ba4f92bce6ab3599c3485b1cc7a0ad0b"
+  integrity sha512-zQt/Gd1+W+IY+h/xX2NYMW4orQWhqSwyV+xsblycTtpOuB27h1fZhhNQuipJ4t79ohw4P4mMem0jp/ZkISQtjQ==
   dependencies:
     JSONStream "^1.0.3"
     assert "^1.4.0"
@@ -3609,19 +3609,19 @@ cloneable-readable@^1.0.0:
     process-nextick-args "^2.0.0"
     readable-stream "^2.3.5"
 
-[email protected].0:
-  version "2.3.0"
-  resolved "https://registry.npmjs.org/closure-builder/-/closure-builder-2.3.0.tgz#57cecbcdcee786ba39946f96f51bd7b72b0373c2"
-  integrity sha512-mdZDxmgCXaUCC5wmJdrZfDnFSuKaBluDdaD4jiukPoIlNsP/NjY6djBngMXNhxDNEKn4+eyKySc24W0T1Njg1w==
+[email protected].4:
+  version "2.3.4"
+  resolved "https://registry.npmjs.org/closure-builder/-/closure-builder-2.3.4.tgz#78f3d65c368b57fe4dd7b9780096ca44b36ea5dd"
+  integrity sha512-rC7RKuQPZoMhDOMUQ7h+tfslfNAqEYrpZAeHw2tFD3v05LZhV2DPKVXATK+YnycVpI/846WuMDEHy5s3MHR0RA==
   dependencies:
-    browserify "^16.2.2"
+    browserify "^16.2.3"
     clean-css "^4.2.1"
     decompress "^4.2.0"
     dns-sync "^0.1.3"
-    follow-redirects "^1.5.8"
+    follow-redirects "^1.5.10"
     fs-extra "^6.0.1"
     glob "7.1.2"
-    google-closure-compiler "^20180805.0.0"
+    google-closure-compiler "^20181210.0.0"
     loglevel "^1.6.1"
     marked "^0.3.19"
     mkdirp "0.5.1"
@@ -3630,7 +3630,7 @@ [email protected]:
     rimraf "^2.6.2"
     rollup "^0.58.2"
     touch "3.1.0"
-    validator "^10.7.1"
+    validator "^10.9.0"
 
 cmd-shim@^2.0.2:
   version "2.0.2"
@@ -4416,14 +4416,14 @@ debug@2, [email protected], debug@^2, debug@^2.1.2, debug@^2.2.0, debug@^2.3.3, debug@
   dependencies:
     ms "2.0.0"
 
-[email protected], debug@=3.1.0, debug@^3.1.0, debug@~3.1.0:
+[email protected], debug@^3.1.0, debug@~3.1.0:
   version "3.1.0"
   resolved "https://registry.npmjs.org/debug/-/debug-3.1.0.tgz#5bb5a0672628b64149566ba16819e61518c67261"
   integrity sha512-OX8XqP7/1a9cqkxYw2yXss15f26NKWBpDXQd0/uK/KPqdQhxbPa994hnzjcE2VqQpDslf55723cKPUOGSmMY3g==
   dependencies:
     ms "2.0.0"
 
-[email protected], debug@^3.0.0:
+[email protected], debug@^3.0.0, debug@^3.2.6:
   version "3.2.6"
   resolved "https://registry.npmjs.org/debug/-/debug-3.2.6.tgz#e83d17de16d8a7efb7717edbe5fb10135eee629b"
   integrity sha512-mel+jf7nrtEl5Pn1Qx46zARXKDpBbvzezse7p7LqINmdoIk8PYP5SySaxEmYv6TZ0JyEKA1hsCId6DIhgITtWQ==
@@ -5981,12 +5981,12 @@ follow-redirects@^1.3.0:
   dependencies:
     debug "^3.1.0"
 
-follow-redirects@^1.5.8:
-  version "1.5.8"
-  resolved "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.5.8.tgz#1dbfe13e45ad969f813e86c00e5296f525c885a1"
-  integrity sha512-sy1mXPmv7kLAMKW/8XofG7o9T+6gAjzdZK4AJF6ryqQYUa/hnzgiypoeUecZ53x7XiqKNEpNqLtS97MshW2nxg==
+follow-redirects@^1.5.10:
+  version "1.7.0"
+  resolved "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.7.0.tgz#489ebc198dc0e7f64167bd23b03c4c19b5784c76"
+  integrity sha512-m/pZQy4Gj287eNy94nivy5wchN3Kp+Q5WgUPNy5lJSZ3sgkVKSYV/ZChMAQVIgx1SqfZ2zBZtPA2YlXIWxxJOQ==
   dependencies:
-    debug "=3.1.0"
+    debug "^3.2.6"
 
 for-in@^1.0.1, for-in@^1.0.2:
   version "1.0.2"
@@ -6686,15 +6686,25 @@ google-auto-auth@^0.9.0:
     google-auth-library "^1.3.1"
     request "^2.79.0"
 
-google-closure-compiler-linux@^20180805.0.0:
-  version "20180805.0.0"
-  resolved "https://registry.npmjs.org/google-closure-compiler-linux/-/google-closure-compiler-linux-20180805.0.0.tgz#f6e0a7dca90a61181a7dea6f5748305645d9a1b7"
-  integrity sha512-Y53/dehGj5/HoAEnxoYFWLpLf8gHq8QaQSOw8ulnh6VkpHPdcAuhRqIVLcLeJ9rVW3xteOMQ2WFyRfFMayVZcA==
+google-closure-compiler-java@^20181210.0.0:
+  version "20181210.0.0"
+  resolved "https://registry.npmjs.org/google-closure-compiler-java/-/google-closure-compiler-java-20181210.0.0.tgz#de0a948aa1951d535c7ee50a529ff6cba00d6832"
+  integrity sha512-FMGzY+vp25DePolYNyVcXz8UI2PV/I3AYU3nuFexmHcKn5XiBVy4CqK7em6NpVbZdDXJYUF3GUv5A0x0gLvbfw==
+
+google-closure-compiler-js@^20181210.0.0:
+  version "20181210.0.0"
+  resolved "https://registry.npmjs.org/google-closure-compiler-js/-/google-closure-compiler-js-20181210.0.0.tgz#806d7e4186828307074b6eb6392d529b40701795"
+  integrity sha512-gn+2hT4uQtYKD/jXJqGIXzPMln3/JD7R4caAKDPJm7adqqDvrCAw7qxAiK4Vz1rNec7hJXPXh9TeKQjzz03ZaQ==
+
+google-closure-compiler-linux@^20181210.0.0:
+  version "20181210.0.0"
+  resolved "https://registry.npmjs.org/google-closure-compiler-linux/-/google-closure-compiler-linux-20181210.0.0.tgz#3bbb44049685b258a095f0d0e5f63a2c58d3d629"
+  integrity sha512-Gp+yp+Vb6QWEhtYkePKxkspRlzX5dx6L46zUoHGWW7Henuk3ACYoUXuaHLQQ+tF0lmi2QAmFXEkvdnKVDIxR+Q==
 
-google-closure-compiler-osx@^20180805.0.0:
-  version "20180805.0.0"
-  resolved "https://registry.npmjs.org/google-closure-compiler-osx/-/google-closure-compiler-osx-20180805.0.0.tgz#71bc29b8dcd4882742709af01466ca1958e229c0"
-  integrity sha512-Zt558FPdkpcZulaT4uH7qNiO5wy3DT2Eaq+JPb4LjuS3KQSo8GSWx9caYWGZ1OdKULTv+v/flkHMtoHu5XP2bw==
+google-closure-compiler-osx@^20181210.0.0:
+  version "20181210.0.0"
+  resolved "https://registry.npmjs.org/google-closure-compiler-osx/-/google-closure-compiler-osx-20181210.0.0.tgz#9f15e37f8abdad809b3e0dd889579e8397042f6c"
+  integrity sha512-SYUakmEpq8BorJU/O5CfrC+ABYjXR0rTvBd3Khwd1sml9B2aKEiHArdHC5SCmBRZd3ccUhp/XyrVO6PoxHKeZA==
 
 [email protected]:
   version "20180402.0.0"
@@ -6705,18 +6715,20 @@ [email protected]:
     vinyl "^2.0.1"
     vinyl-sourcemaps-apply "^0.2.0"
 
-google-closure-compiler@^20180805.0.0:
-  version "20180805.0.0"
-  resolved "https://registry.npmjs.org/google-closure-compiler/-/google-closure-compiler-20180805.0.0.tgz#9e2a9d0794a2033b276ab13c807a3671a7d93dbf"
-  integrity sha512-MV9JTTQDO0tYOAaJmqd3MMIjCLxHkhZcj7hN6gUJdjQV7wYmH2wqwj56teIK22o9pSJvhKg89F/WCguaAZhSUA==
+google-closure-compiler@^20181210.0.0:
+  version "20181210.0.0"
+  resolved "https://registry.npmjs.org/google-closure-compiler/-/google-closure-compiler-20181210.0.0.tgz#148bd30d5e33a83ab656fba8683d6a02063afda4"
+  integrity sha512-GCMLakdibnc+jpdNTvF3M/ET5i6I4zzxGKw67A4bQahxc0TPLXQdkVfhF3kwBSoPfK8xwgU5kA+KO0qvDZHKHw==
   dependencies:
     chalk "^1.0.0"
+    google-closure-compiler-java "^20181210.0.0"
+    google-closure-compiler-js "^20181210.0.0"
     minimist "^1.2.0"
     vinyl "^2.0.1"
     vinyl-sourcemaps-apply "^0.2.0"
   optionalDependencies:
-    google-closure-compiler-linux "^20180805.0.0"
-    google-closure-compiler-osx "^20180805.0.0"
+    google-closure-compiler-linux "^20181210.0.0"
+    google-closure-compiler-osx "^20181210.0.0"
 
 [email protected]:
   version "20180405.0.0"
@@ -15043,10 +15055,10 @@ validate-npm-package-name@^3.0.0:
   dependencies:
     builtins "^1.0.3"
 
-validator@^10.7.1:
-  version "10.7.1"
-  resolved "https://registry.npmjs.org/validator/-/validator-10.7.1.tgz#dd4cc750c2134ce4a15a2acfc7b233669d659c5b"
-  integrity sha512-tbB5JrTczfeHKLw3PnFRzGFlF1xUAwSgXEDb66EuX1ffCirspYpDEZo3Vc9j38gPdL4JKrDc5UPFfgYiw1IWRQ==
+validator@^10.9.0:
+  version "10.11.0"
+  resolved "https://registry.npmjs.org/validator/-/validator-10.11.0.tgz#003108ea6e9a9874d31ccc9e5006856ccd76b228"
+  integrity sha512-X/p3UZerAIsbBfN/IwahhYaBbY68EN/UQBWHtsbXGT5bfrH/p4NQzUCG1kF/rtKaNpnJ7jAu6NGTdSNtyNIXMw==
 
 value-or-function@^3.0.0:
   version "3.0.0"