-
Notifications
You must be signed in to change notification settings - Fork 339
Firestore API #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore API #79
Conversation
The build failure is caused by googleapis/google-cloud-python#4115 Awaiting resolution. In the worst case, we will have to give up Python 3.3 compatibility. |
As worst cases go, giving up Python 3.3 isn't such a bad one, it's EOL: https://en.wikipedia.org/wiki/CPython#Version_history By the way, it might be an idea to also test 3.4 and 3.6 on Travis CI. |
Fixed the test failure by installing |
'population': 77846, | ||
'capital': False | ||
} | ||
doc = client.collection('cities').document() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the credentials to run this stored? Can this only be run on jenkins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually don't run integration tests on Travis. Developers like you and I could run the integration tests locally by providing credentials explicitly. See https://github.com/firebase/firebase-admin-python/blob/master/CONTRIBUTING.md#integration-testing for details.
Is there likely to be any significant API change before this is merged in? We've been waiting on this update for two weeks now in order to release our product. I'm going to start implementing with this branch in the hopes that it is merged by the time I'm done :) Thanks for your work! |
I see you got Python 3.3 working. Anyway, here's the pip installs for firebase-admin from PyPI for the last month, showing very low usage for 3.3:
|
@craigsheppard The API is stable now. I'm working with various parties involved to get the release out, but I still don't have a fixed date yet. In the mean time, please do feel free to use this branch. Thanks for being patient :) |
Any idea when this will merge to master? Thanks again! |
I'm hoping next week. Fingers crossed :) |
Usage: