Skip to content

Firestore API #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 2, 2017
Merged

Firestore API #79

merged 10 commits into from
Nov 2, 2017

Conversation

hiranya911
Copy link
Contributor

Usage:

from firebase_admin import firestore

db = firestore.client()

@hiranya911
Copy link
Contributor Author

The build failure is caused by googleapis/google-cloud-python#4115

Awaiting resolution. In the worst case, we will have to give up Python 3.3 compatibility.

@hugovk
Copy link

hugovk commented Oct 4, 2017

As worst cases go, giving up Python 3.3 isn't such a bad one, it's EOL:

https://en.wikipedia.org/wiki/CPython#Version_history

By the way, it might be an idea to also test 3.4 and 3.6 on Travis CI.

@hiranya911 hiranya911 self-assigned this Oct 16, 2017
@hiranya911
Copy link
Contributor Author

Fixed the test failure by installing enum34 as advised.

@hiranya911 hiranya911 requested a review from bjornick October 16, 2017 19:42
@hiranya911 hiranya911 assigned bjornick and unassigned hiranya911 Oct 16, 2017
'population': 77846,
'capital': False
}
doc = client.collection('cities').document()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the credentials to run this stored? Can this only be run on jenkins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually don't run integration tests on Travis. Developers like you and I could run the integration tests locally by providing credentials explicitly. See https://github.com/firebase/firebase-admin-python/blob/master/CONTRIBUTING.md#integration-testing for details.

@craigsheppard
Copy link

Is there likely to be any significant API change before this is merged in? We've been waiting on this update for two weeks now in order to release our product. I'm going to start implementing with this branch in the hopes that it is merged by the time I'm done :) Thanks for your work!

@hugovk
Copy link

hugovk commented Oct 23, 2017

I see you got Python 3.3 working. Anyway, here's the pip installs for firebase-admin from PyPI for the last month, showing very low usage for 3.3:

$ pypinfo --percent --pip firebase-admin pyversion
python_version percent download_count
-------------- ------- --------------
2.7              59.8%          2,549
3.6              23.9%          1,018
3.5              11.7%            501
3.4               4.0%            169
3.3               0.6%             24
2.6               0.1%              5

@hiranya911
Copy link
Contributor Author

@craigsheppard The API is stable now. I'm working with various parties involved to get the release out, but I still don't have a fixed date yet. In the mean time, please do feel free to use this branch. Thanks for being patient :)

@hiranya911 hiranya911 assigned hiranya911 and unassigned bjornick Oct 25, 2017
@hiranya911 hiranya911 mentioned this pull request Oct 28, 2017
@craigsheppard
Copy link

Any idea when this will merge to master? Thanks again!

@hiranya911
Copy link
Contributor Author

I'm hoping next week. Fingers crossed :)

@hiranya911 hiranya911 merged commit 0502423 into master Nov 2, 2017
@hiranya911 hiranya911 deleted the hkj-firestore-py branch November 2, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants