Implement the possibility to waive missing requirements via bodhi-cli #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cverna
reviewed
Jul 11, 2018
bodhi/client/__init__.py
Outdated
| click.echo( | ||
| 'You can not list the unsatisfied requirements and waive them at the same ' | ||
| 'time, please use either --show or --test=... but not both.') | ||
| return |
There was a problem hiding this comment.
other command are using sys.exit(1) in that case, we could try to stay consistent
There was a problem hiding this comment.
also it seems that ERROR: is added at the beginning of the message just like here https://github.com/fedora-infra/bodhi/blob/develop/bodhi/client/__init__.py#L576
bodhi/client/__init__.py
Outdated
| else: | ||
| if not comment: | ||
| click.echo('Comment are mandatory when waiving unsatisfied requirements') | ||
| return |
There was a problem hiding this comment.
same here, we could use sys.exit(1) and add the ERROR: in front of the message
This commit basically implements the command: bodhi update waive, see --help for the arguments. It queries greenwave via bodhi to know the list of unsatisfied requirements and uses the waiving endpoint in bodhi's API to waive either all or just some of them. Signed-off-by: Pierre-Yves Chibon <[email protected]>
|
👍 |
|
This patch is planned to be included in the upcoming 3.9.0 release: #2477. |
|
This patch was released with 3.9.0 last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit basically implements the command: bodhi update waive, see
--help for the arguments.
It queries greenwave via bodhi to know the list of unsatisfied
requirements and uses the waiving endpoint in bodhi's API to waive either
all or just some of them.
Signed-off-by: Pierre-Yves Chibon [email protected]