Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move default python version to 3.10 #2106

Merged

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Aug 30, 2022

No description provided.

@CaselIT CaselIT requested review from kgriffs and vytas7 August 30, 2022 18:59
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #2106 (4981872) into master (bce4ad3) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            master     #2106     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           62        55      -7     
  Lines         6759      5552   -1207     
  Branches      1255       880    -375     
===========================================
- Hits          6759      5552   -1207     
Impacted Files Coverage Δ
falcon/asgi/app.py 100.00% <0.00%> (ø)
falcon/constants.py 100.00% <0.00%> (ø)
falcon/media/base.py 100.00% <0.00%> (ø)
falcon/asgi/reader.py 100.00% <0.00%> (ø)
falcon/util/reader.py 100.00% <0.00%> (ø)
falcon/asgi/multipart.py 100.00% <0.00%> (ø)
falcon/media/multipart.py 100.00% <0.00%> (ø)
falcon/testing/helpers.py 100.00% <0.00%> (ø)
falcon/routing/converters.py 100.00% <0.00%> (ø)
falcon/asgi/__init__.py
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kgriffs
Copy link
Member

kgriffs commented Sep 28, 2022

Added some cython jobs; I know this increases the CI duration but I'd rather be safe than sorry.

kgriffs
kgriffs previously approved these changes Sep 28, 2022
@CaselIT
Copy link
Member Author

CaselIT commented Sep 29, 2022

thanks!

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@vytas7 vytas7 merged commit f9647c8 into falconry:master Oct 3, 2022
@CaselIT CaselIT deleted the modernize_various_python_version_used_in_tests branch November 23, 2022 21:47
vytas7 added a commit that referenced this pull request Nov 12, 2023
* chore: move default python version to 3.10

* chore: some tox env require python 3.8

* chore(ci): add cython jobs

* chore: fix misspelled pkg name greenlen (sic) ==> greenlet

* style: trim trailing whitespace

Co-authored-by: Kurt Griffiths <[email protected]>
Co-authored-by: Vytautas Liuolia <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants