-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surgery clear-elements
command
#408
Conversation
Points: 1. There are lots of duplicated definitions between bolt and guts_cli, which is definitely not good. 2. The implementation in guts_cli also has issue, please refer to #391. This refactoring can fix the issue. Signed-off-by: Benjamin Wang <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
Still need to add a couple of unit test cases |
Thanks, It works for me. |
Signed-off-by: Benjamin Wang <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
I know it's not how bbolt used to be doing the syntax, but maybe starting with new commands and bbolt 1.4,
WDYT ? |
Sounds good to me. I will try to add the new command using cobra. And refactoring other commands in separate PRs later. |
This PR will be superseded by #417 |
This PR is on top of #407. It can be used to fix the corrupted db file in #402.
Steps to fix the db file are as below.
new3.db
is the final db file,Note we still need to investigate the root cause of the corruption.