setTimeCallback is not working for ESP8266 with both SD.h and SDFS too

[akoro]

Basic Infos

• [x ] This issue complies with the issue POLICY doc.
• [x ] I have read the documentation at readthedocs and the issue is not addressed there.
• [x ] I have tested that the issue is present in current master branch (aka latest git).
• [x ] I have searched the issue tracker for a similar issue.
• [x ] If there is a stack dump, I have decoded it.
• [x ] I have filled out all fields below.

Platform

• Hardware: ESP-12
• Core Version: 2.6.2
• Development Env: Platformio
• Operating System: Windows

Settings in IDE

• Module: Generic ESP8266 Module
• Flash Mode: dio
• Flash Size: 4MB
• lwip Variant: v1.4
• Reset Method: nodemcu
• Flash Frequency: 40Mhz
• CPU Frequency: 80Mhz
• Upload Using: SERIAL
• Upload Speed: 460800

Problem Description

setTimeCallback is not working for ESP8266 with both SD.h and SDFS too
TimeCallback function isn't calling at all

#include <SPI.h>
#include <time.h>
#include <SDFS.h>
using namespace sdfs;

SDFSConfig cfg(SS);

// TimeCallback function:
time_t my_time(void)
{
  struct tm t;
  t.tm_year = 120;
  t.tm_mon  = 9;
  t.tm_mday = 22;
  t.tm_hour = 12;
  t.tm_min  = 13;
  t.tm_sec  = 14;
  Serial.print("*");
  return mktime(&t);
}

void setup()
{
  Serial.begin(115200);
  while (!Serial) yield();
...
  // SD card init
  SDFS.setConfig(cfg);
  SDFS.setTimeCallback(my_time); // does not work!!!
  SDFS.begin();
...
  String fname = "new_file.txt"

  File file = SDFS.open(fname, "w");
  if (file)
  {
    file.write("12457845122\r\n");
    file.write("12457845122\r\n");
    file.write("12457845122\r\n");
    file.write("12457845122\r\n");
    file.write("12457845122\r\n");
    file.close();
    Serial.printf("create %s OK\n", fname.c_str());
  }
  else
    Serial.printf("create %s failed\n", fname.c_str());
...
    
}

The file created normal but his timestamp is not expected.
And "*" is not printing, so my_time() does not call.

The part of the directory list output:
1961-11-25 17:32:20 new_file.txt 65

Similar issue

[earlephilhower]

Please give the PR above a try and report back. The plumbing for SDFat<->userTimeCallback wasn't built originally, as commented in the header. It's hooked in now in the PR with a CI test.

[akoro]

Thank you!
It does work now.
I have made patches in SDFS.cpp and SDFS.h
Testing code is below. I have "OK OK" in the output. And my origin project works too.

#include <SPI.h>
#include <FS.h>
#include "SDFS.h"

// SDFS timestamp setter (#7682)
static time_t _my_time(void)
{
    struct tm t;
    bzero(&t, sizeof(t));
    t.tm_year = 120;
    t.tm_mon  = 9;
    t.tm_mday = 22;
    t.tm_hour = 12;
    t.tm_min  = 13;
    t.tm_sec  = 14;
    return mktime(&t);
}

SDFSConfig cfg(SS);

void setup(void)
{
  Serial.begin(115200);
  while (!Serial) yield();
  Serial.println();

  SDFS.setConfig(cfg);
  if(SDFS.begin())
  {
    SDFS.setTimeCallback(_my_time);

    File f = SDFS.open("/file.txt", "w");
    f.write("Had we but world enough, and time,");
    f.close();
    time_t expected = _my_time();
    f = SDFS.open("/file.txt", "r");
    if(abs(f.getCreationTime() - expected) < 60)
      Serial.println("OK");
    else
      Serial.println("?");
    if(abs(f.getLastWrite() - expected) < 60)
      Serial.println("OK");
    else
      Serial.println("?");
    
    f.close();
  }
}

void loop(){}