Suggest marking stopWaveForm with ICACHE_RAM_ATTR

[chyrtsik]

Arduino/cores/esp8266/core_esp8266_waveform.c

Line 205 in 2eb5b56

int stopWaveform(uint8_t pin) {

I had a problem with custom servo implementation. I am using hardware serial to parallel port extension. Needed to change servo implementation to send serial code for each servo pulse.
Code crashed in case eps is connecting to a wifi at the time when servo is active. If servo is activated after the connection, it works. If it is activated before the wifi connection (my device works with and without connection), it crashes (attached stac traces).

While debugging, I found, that the new ESP core (2.4.2) calls stopWaveForm in each call to a _digitalWrite. This new implementation (comparing to the pwm-one, the old one,

Arduino/cores/esp8266/core_esp8266_wiring_pwm.c

Line 168 in ea4720b

void ICACHE_RAM_ATTR pwm_stop_pin(uint8_t pin)

), does not have method marked with ICACHE_RAM_ATTR. Adding this section definition to a method fixed the crash for me.

Suggest to evaluate this change to be included in the esp core.

stacktrace.txt
stacktrace-parsed.txt

[chyrtsik]

Thank you for the very fast fix!