Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google import #119

Closed
4 tasks done
htuch opened this issue Aug 19, 2019 · 2 comments
Closed
4 tasks done

Google import #119

htuch opened this issue Aug 19, 2019 · 2 comments
Assignees

Comments

@htuch
Copy link
Member

htuch commented Aug 19, 2019

There are a number of things we need to ensure we can cleanly import Nighthawk into Google:

  • service_main.cc needs to be able to handle IPv6 addresses. Its test, service_main_test.cc, should work with TestEnvironment::getIpVersionsForTest.
  • service_test.cc and process_test.cc also need to consume from TestEnvironment::getIpVersionsForTest when forming loopback addresses.
  • We need to switch Envoy import paths from overlay to external/envoy based and structurally enforce this.
  • We need to eliminate the race being fixed in Service: address back to back execution race #118
@oschaaf
Copy link
Member

oschaaf commented Aug 20, 2019

I have been looking getting the include path overlay fixed.
There now is a candidate script to test for this: #122, but unfortunately updating the include paths as planned causes the build to fail.

@oschaaf
Copy link
Member

oschaaf commented Aug 20, 2019

status update:

  • the fix for the observed race in the service is in review, pending discussion.
  • maybe we should brainstorm on slack to see if we can come up with a plan B for disambiguating the Envoy include paths; the script to check for what we do not want to see is implemented, but actually updating the include paths doesn't seem to work for me (see the comment above).
  • I'll look into getting the ipv6 handling sorted tomorrow.

@oschaaf oschaaf self-assigned this Aug 24, 2019
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Aug 27, 2019
This adresses the last ambiguoys includes paths, plus
has some cleanup.

Needed for envoyproxy#119

This needs envoyproxy/envoy#8045

Signed-off-by: Otto van der Schaaf <[email protected]>
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Aug 27, 2019
Re-route the last few include that couldn't go via
`external/envoy/...` earler, plus some cleanup.

Needed for envoyproxy#119

This needs envoyproxy/envoy#8045

Signed-off-by: Otto van der Schaaf <[email protected]>
htuch pushed a commit that referenced this issue Aug 27, 2019
This adresses the last ambiguous includes paths, and contains some cleanup.

Needed for #119

Signed-off-by: Otto van der Schaaf <[email protected]>
htuch pushed a commit that referenced this issue Aug 27, 2019
Addresses some of the things needed for #119

Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf oschaaf closed this as completed Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants