-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google import #119
Comments
I have been looking getting the include path overlay fixed. |
status update:
|
oschaaf
added a commit
to oschaaf/nighthawk
that referenced
this issue
Aug 27, 2019
This adresses the last ambiguoys includes paths, plus has some cleanup. Needed for envoyproxy#119 This needs envoyproxy/envoy#8045 Signed-off-by: Otto van der Schaaf <[email protected]>
oschaaf
added a commit
to oschaaf/nighthawk
that referenced
this issue
Aug 27, 2019
Re-route the last few include that couldn't go via `external/envoy/...` earler, plus some cleanup. Needed for envoyproxy#119 This needs envoyproxy/envoy#8045 Signed-off-by: Otto van der Schaaf <[email protected]>
htuch
pushed a commit
that referenced
this issue
Aug 27, 2019
This adresses the last ambiguous includes paths, and contains some cleanup. Needed for #119 Signed-off-by: Otto van der Schaaf <[email protected]>
htuch
pushed a commit
that referenced
this issue
Aug 27, 2019
Addresses some of the things needed for #119 Signed-off-by: Otto van der Schaaf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a number of things we need to ensure we can cleanly import Nighthawk into Google:
service_main_test.cc
, should work withTestEnvironment::getIpVersionsForTest
.TestEnvironment::getIpVersionsForTest
when forming loopback addresses.external/envoy
based and structurally enforce this.The text was updated successfully, but these errors were encountered: