docs: fix indentation in the compressor filter configuration #30515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <[email protected]>
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/30515/docs/index.html The docs are (re-)rendered each time the CI |
phlax
reviewed
Oct 26, 2023
There was a problem hiding this comment.
@spacewander would you mind shifting this config to a yaml file and using a literalinclude
that way it will be validated and linted automatically
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
phlax
approved these changes
Oct 27, 2023
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Oct 27, 2023
…nvoyproxy#30515)" This reverts commit 8c7e9ac. Signed-off-by: Ryan Northey <[email protected]>
phlax
added a commit
that referenced
this pull request
Oct 27, 2023
#30575) Revert "docs: fix indentation in the compressor filter configuration (#30515)" This reverts commit 8c7e9ac. Signed-off-by: Ryan Northey <[email protected]>
spacewander
added a commit
to spacewander/envoy
that referenced
this pull request
Oct 28, 2023
…oxy#30515) Signed-off-by: spacewander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes: docs/root/configuration/http/http_filters/compressor_filter.rst
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]