Reduce overhead in SubsetSelectorImpl by fixing alignment #25644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AlanDiaz <[email protected]>
|
/retest |
|
Retrying Azure Pipelines: |
adisuissa
reviewed
Feb 21, 2023
| @@ -757,10 +757,10 @@ class SubsetSelectorImpl : public SubsetSelector { | |||
|
|
|||
| private: | |||
| const std::set<std::string> selector_keys_; | |||
| const std::set<std::string> fallback_keys_subset_; | |||
There was a problem hiding this comment.
Why was this field moved to the end?
There was a problem hiding this comment.
I wasn't moved down, it was moved up above an enum
There was a problem hiding this comment.
Ah... misread the change. That makes sense.
Can you please add a relevant comment (before the enum) similar to other PRs?
Signed-off-by: AlanDiaz <[email protected]>
|
/retest |
|
Retrying Azure Pipelines: |
adisuissa
approved these changes
Feb 22, 2023
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
|
/retest |
|
Retrying Azure Pipelines: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Reduce overhead in SubsetSelectorImpl by fixing alignment
Additional Description: Moves many of the smaller members of the class to the end to save small amounts of memory
Risk Level: Low