build: use 20.04 based image #21388
build: use 20.04 based image #21388
Conversation
Signed-off-by: Lizan Zhou <[email protected]>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
bazel/repository_locations.bzl
Outdated
| version = "9cdf86f3fe383c7f894d1814da3f0bc5bec8c8c4", | ||
| sha256 = "88e76fdd6b2ee52e66b6b5933eb25e4263285c8b6133b330699c8796c28da606", | ||
| version = "08c1f7edd91d5c891e8b94e87f0eafa6b4224fad", | ||
| sha256 = "2b12185033fb9178dfaba24412004f89f36263dec1f06c039d9e718e5533d500", | ||
| strip_prefix = "envoy-build-tools-{version}", | ||
| urls = ["https://github.com/envoyproxy/envoy-build-tools/archive/{version}.tar.gz"], | ||
| release_date = "2022-05-12", |
There was a problem hiding this comment.
release_date = "2022-05-18",
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
|
@lizan can you fix CI to get this merged? Thanks. |
|
iiuc some of the CI fails are kinda genuine - the binaries that are being built are not finding the host glibc i think not sure exactly the implications - but it may mean we just need to shift which OS flavours we support |
Yeah this is the problem and I'm trying to figure out what's the best way. Are we comfortable drop 18.04 support from deb distribution? |
at this point i think its a case of support what we support out of the box, and figure out the peripherals once we have that sorted |
|
(as an aside - im sooooo pleased you triggered this error. Setting up the distro tests took a lot of effort and i was ambivalent about how useful - but this was one of the main things they were intended to catch, so it feels like it was worth it after all) |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@lizan not sure how you want to proceed with this - lmk if you want me to raise a PR to drop ubuntu 18.04 support from the distro/tests |
|
@phlax Yeah my plan is to drop 18.04 support, though I think we can wait a bit until 1.23.0 release. |
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
|
@phlax @mattklein123 this is good to go |
There was a problem hiding this comment.
when i saw this change i was kinda hesitant as it would be good to support 2 debian versions (i use debian as a ref implementation, on the assumption that this will give a reasonable indication of other deb-based distros)
after thinking about it - i guess we are a year into bullseye (altho next is still a year out)
so lgtm - with the caveat that this may well break some existing users
Fixes #21171
Additional Description:
Risk Level: Med
Testing: CI
Docs Changes: Done
Release Notes: Done
Platform Specific Features: