ci: Update shellcheck and build image hashes #13362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
commented
Oct 1, 2020
| @@ -19,8 +19,7 @@ run_shellcheck_on () { | |||
| local file | |||
| file="$1" | |||
| echo "Shellcheck: ${file}" | |||
| # TODO: add -f diff when shellcheck version allows (ubuntu > bionic) | |||
| shellcheck -x "$file" | |||
| shellcheck -f diff -x "$file" | |||
There was a problem hiding this comment.
this will fail until shellcheck is updated
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
|
@mattklein123 i think the envoy-build-tools PR (envoyproxy/envoy-build-tools#103) didnt land yet |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
8deed43
to
ba40377
Compare
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
|
Hopefully this will work with the new image that is about to get built. /wait |
Signed-off-by: Ryan Northey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: ci: Update shellcheck and build image hashes
Additional Description:
some shellcheck cleanups that are required once shellcheck is updated
this pr needs to /wait until envoyproxy/envoy-build-tools#103 lands and to have the new build image hashes added
Risk Level: low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fixes #13228
[Optional Deprecated:]