Skip to content

Conversation

rmyz
Copy link
Contributor

@rmyz rmyz commented Apr 8, 2025

Summary

Closes #194975

This PR improves the aria-label attributes in the latency correlations page to add more context about the selected field.

@rmyz rmyz added apm Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team backport:version Backport to applied version labels a11y Accessibility issue v8.19.0 labels Apr 8, 2025
@rmyz rmyz self-assigned this Apr 8, 2025
@rmyz rmyz requested a review from a team as a code owner April 8, 2025 13:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rmyz rmyz added the v9.0.1 label Apr 9, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.6MB 2.6MB +180.0B

History

cc @rmyz

@rmyz rmyz merged commit 6190ca8 into elastic:main Apr 10, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14377535463

@rmyz rmyz deleted the 194975-a11y-apm-improve-aria-labels-for-correlations branch April 10, 2025 09:53
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 10, 2025
## Summary

Closes elastic#194975

This PR improves the `aria-label` attributes in the latency correlations
page to add more context about the selected field.

(cherry picked from commit 6190ca8)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 10, 2025
## Summary

Closes elastic#194975

This PR improves the `aria-label` attributes in the latency correlations
page to add more context about the selected field.

(cherry picked from commit 6190ca8)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 10, 2025
## Summary

Closes elastic#194975

This PR improves the `aria-label` attributes in the latency correlations
page to add more context about the selected field.

(cherry picked from commit 6190ca8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 10, 2025
…17810)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[A11y][APM] Improve `aria-label` for correlations
(#217512)](#217512)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-10T09:52:11Z","message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM]
Improve `aria-label` for
correlations","number":217512,"url":"https://github.com/elastic/kibana/pull/217512","mergeCommit":{"message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217512","number":217512,"mergeCommit":{"message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 10, 2025
…217808)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[A11y][APM] Improve `aria-label` for correlations
(#217512)](#217512)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-10T09:52:11Z","message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM]
Improve `aria-label` for
correlations","number":217512,"url":"https://github.com/elastic/kibana/pull/217512","mergeCommit":{"message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217512","number":217512,"mergeCommit":{"message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 10, 2025
…17809)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[A11y][APM] Improve `aria-label` for correlations
(#217512)](#217512)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-10T09:52:11Z","message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM]
Improve `aria-label` for
correlations","number":217512,"url":"https://github.com/elastic/kibana/pull/217512","mergeCommit":{"message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217512","number":217512,"mergeCommit":{"message":"[A11y][APM]
Improve `aria-label` for correlations (#217512)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/194975\n\nThis PR improves the
`aria-label` attributes in the latency correlations\npage to add more
context about the selected
field.","sha":"6190ca8c140a4faba7a75b70a33e79736dd937fe"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
@mistic mistic added v8.18.1 and removed v8.18.0 labels Apr 15, 2025
@mistic
Copy link
Member

mistic commented Apr 15, 2025

This PR didn't make it into the latest BC. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue apm backport:version Backport to applied version labels release_note:fix Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.1 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Obs Services > Service Sub-transaction][SCREEN READER] Icons and repeated controls need unique accessible labels: 0008
5 participants