Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean fields should render as true/false rather than 1/0 #7898

Closed
3ygun opened this issue Aug 1, 2016 · 3 comments
Closed

Boolean fields should render as true/false rather than 1/0 #7898

3ygun opened this issue Aug 1, 2016 · 3 comments

Comments

@3ygun
Copy link

3ygun commented Aug 1, 2016

Current behavior: A field that is mapped as a boolean field when visualized shows 0 & 1 example:

boolean current

Expected behavior: A field that is mapped as a boolean should display as true & false.

Why? The JSON true & false is how it is inserted into Elasticsearch why should it change?

Adding a field type formatter for booleans would be a way to fix the problem

User pain:

@epixa epixa changed the title Default Field Formatter for boolean values Boolean fields should render as true/false rather than 1/0 Aug 3, 2016
@thomasneirynck thomasneirynck self-assigned this Aug 3, 2016
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Aug 4, 2016

This occurs with all visualizations showing boolean aggregations. e.g also bar charts.

So it does not just appear in the legend, but also on the Axes.

0e01a084-5a3e-11e6-8d95-a063ad0eab06

@thomasneirynck
Copy link
Contributor

The reason for the discrepancy between the display of booleans on the summary of on the Discover page and between the charts on the Visualize-page is due to the fact that ES already formats the responses server-side. For aggregations, ES does not format the response in human readable format, and instead casts booleans to 0 and 1.

@thomasneirynck
Copy link
Contributor

Addressed by #7935.

jbudz pushed a commit that referenced this issue Sep 10, 2024
`v95.9.0`⏩`v95.10.1`

> [!note]
> **EuiDataGrid**'s header cells have received a major UX change in
order to support interactive children within header content. Column
header actions now must be hovered and then clicked directly, or opened
with the Enter key, as opposed to being able to click the entire header
cell to see the actions popover.

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.10.0`](https://github.com/elastic/eui/releases/v95.10.0)

- Updated `EuiDataGrid` to support interactive header cell content
([#7898](elastic/eui#7898))
- Updated `EuiSearchBar`'s `field_value_selection` filter type with a
new `autoSortOptions` config, allowing consumers to configure whether or
not selected options are automatically sorted to the top of the filter
list ([#7958](elastic/eui#7958))
- Updated `getDefaultEuiMarkdownPlugins` to support the following new
default plugin configurations:
([#7985](elastic/eui#7985))
- `parsingConfig.linkValidator`, which allows configuring
`allowRelative` and `allowProtocols`
  - `parsingConfig.emoji`, which allows configuring emoticon parsing
- `processingConfig.linkProps`, which allows configuring rendered links
with any props that `EuiLink` accepts
- See our **Markdown plugins** documentation for example
`EuiMarkdownFormat` and `EuiMarkdownEditor` usage
- Updated `EuiDatePicker` to support `append` and `prepend` nodes in its
form control layout ([#7987](elastic/eui#7987))

**Bug fixes**

- Fixed border rendering bug with inline `EuiDatePicker`s with
`shadow={false}` ([#7987](elastic/eui#7987))
- Fixed `EuiSuperSelect`'s placeholder text color to match other form
controls ([#7995](elastic/eui#7995))

**Accessibility**

- Improved the keyboard navigation and screen reader output for
`EuiDataGrid` header cells
([#7898](elastic/eui#7898))

## [`v95.10.1`](https://github.com/elastic/eui/releases/v95.10.1)

**Bug fixes**

- Fixed a visual bug in compact density `EuiDataGrid`s, where the header
cell height would increase when the actions button became visible
([#7999](elastic/eui#7999))

---------

Co-authored-by: Lene Gadewoll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants