Skip to content

threatq: add user configurable page size #9922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2024

Conversation

adrianchen-es
Copy link
Contributor

@adrianchen-es adrianchen-es commented May 20, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@adrianchen-es adrianchen-es requested a review from a team as a code owner May 20, 2024 05:47
@adrianchen-es adrianchen-es self-assigned this May 20, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
Copy link
Contributor

efd6 commented May 20, 2024

Why is this in the PR description?

Note: At this point, this is too late, but I think it may have been a better initial choice to just expose the oauth config tree as a YAML field.

@efd6
Copy link
Contributor

efd6 commented May 20, 2024

/test

@adrianchen-es adrianchen-es added the enhancement New feature or request label May 20, 2024
@adrianchen-es
Copy link
Contributor Author

Why is this in the PR description?

Note: At this point, this is too late, but I think it may have been a better initial choice to just expose the oauth config tree as a YAML field.

That was incorrectly leftover from a copy and paste.

@adrianchen-es
Copy link
Contributor Author

/test

efd6
efd6 previously approved these changes May 20, 2024
@efd6 efd6 dismissed their stale review May 20, 2024 23:18

finger fumble

@adrianchen-es
Copy link
Contributor Author

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @adrianchen-es

Copy link

@adrianchen-es adrianchen-es merged commit fd93f89 into elastic:main May 21, 2024
@adrianchen-es adrianchen-es deleted the 9921-threatq-custom-limits branch May 21, 2024 03:32
@elasticmachine
Copy link

Package ti_threatq - 1.26.0 containing this change is available at https://epr.elastic.co/search?package=ti_threatq

@andrewkroh andrewkroh added the Integration:ti_threatq ThreatQuotient (Partner supported) label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:ti_threatq ThreatQuotient (Partner supported)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants