Skip to content

Migrate PostgreSQL modules #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jun 16, 2020

In the list of Integrations:

image

Overview of the integration:

image

Part of fields and example event in description:

image

Configuration of logging:

image

Configuration of metrics:

image

Postgresql logs overview:

image

Postgresql metrics overview:

image

@elasticmachine
Copy link

elasticmachine commented Jun 16, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-06-27T17:24:23.865+0000

  • Duration: 5 min 1 sec

@mtojek
Copy link
Contributor

mtojek commented Jun 16, 2020

@kvch

Thank for your contribution. Is this still a draft or it's ready to be reviewed? Feel free to add label for the team.

It would great to see some screenshots from Kibana (PR description) if this integration is running. We used to take screenshots presenting configuration options and working dashboards.

@kvch kvch added the Team:Integrations Label for the Integrations team label Jun 18, 2020
@mtojek
Copy link
Contributor

mtojek commented Jun 24, 2020

Based on the posted screenshots of forms, it's in the really good shape! Did you try with dashboards, @kvch ?

@kvch kvch force-pushed the migrate-package-postgresql branch from 380976c to 73c3025 Compare June 25, 2020 13:54
@kvch
Copy link
Contributor Author

kvch commented Jun 25, 2020

@mtojek I've just added all required screenshots. This PR is ready for review.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions here. I think that once they're solved, we can merge this PR.

Also, feel free to jump into other PRs. Your integration is in a good shape, you can share opinion on others work. Thanks for the contribution, Noemi :)

@mtojek
Copy link
Contributor

mtojek commented Jun 26, 2020

I'm not quite sure about the SIGSEGV issue on the CI side. Could you please rerun tests?

[2020-06-25T17:33:55.863Z] [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x5cfe05]

[2020-06-25T17:33:55.863Z] 

[2020-06-25T17:33:55.863Z] goroutine 1 [running]:

[2020-06-25T17:33:55.863Z] main.init.0()

[2020-06-25T17:33:55.863Z] 	/go/src/golang.org/x/tools/cmd/goimports/goimports.go:51 +0x85

@kvch
Copy link
Contributor Author

kvch commented Jun 26, 2020

@mtojek I've addressed your remaining concerns. Also, the CI issue seems transient. It is no longer a problem.

@mtojek mtojek self-requested a review June 26, 2020 11:14
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all adjustments. Ship it!

@kvch kvch merged commit 5f74f98 into elastic:master Jun 29, 2020
@kvch kvch mentioned this pull request Jun 29, 2020
@andrewkroh andrewkroh added Integration:postgresql PostgreSQL New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:postgresql PostgreSQL New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants