-
Notifications
You must be signed in to change notification settings - Fork 474
Migrate PostgreSQL modules #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank for your contribution. Is this still a draft or it's ready to be reviewed? Feel free to add label for the team. It would great to see some screenshots from Kibana (PR description) if this integration is running. We used to take screenshots presenting configuration options and working dashboards. |
Based on the posted screenshots of forms, it's in the really good shape! Did you try with dashboards, @kvch ? |
380976c
to
73c3025
Compare
@mtojek I've just added all required screenshots. This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions here. I think that once they're solved, we can merge this PR.
Also, feel free to jump into other PRs. Your integration is in a good shape, you can share opinion on others work. Thanks for the contribution, Noemi :)
I'm not quite sure about the SIGSEGV issue on the CI side. Could you please rerun tests?
|
@mtojek I've addressed your remaining concerns. Also, the CI issue seems transient. It is no longer a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all adjustments. Ship it!
In the list of Integrations:
Overview of the integration:
Part of fields and example event in description:
Configuration of logging:
Configuration of metrics:
Postgresql logs overview:
Postgresql metrics overview: