-
Notifications
You must be signed in to change notification settings - Fork 474
[Postgresql] [Bugfix] create new field query_id field to replace query field as dimension field #8248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌐 Coverage report
|
Index mappings after the change "query": {
"type": "keyword",
"ignore_above": 1024
},
"query_id": {
"type": "keyword",
"time_series_dimension": true
}, |
@agithomas, @aliabbas-elastic, Can we reproduce and verify that the issue is getting resolved by the PR? BTW, I am able to get a user query populated into: postgresql.activity.query ![]() |
Sure @lalit-satapathy Let me look into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The original below error was not reproduced during the testing. The fix should address the issue.
Dimension fields must be less than [1024] bytes but was [1307]
Package postgresql - 1.17.1 containing this change is available at https://epr.elastic.co/search?package=postgresql |
Proposed commit message
WHAT: The change helps to prevent the errors of storing data in ES when the query field in pg_stat_activity table exceeds 1024 byte length.
WHY: The length of the values stored in the query field can extend beyond 1024 bytes, which is the limit of dimension field length after a limit override
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Screenshots
Priority
High.