[AWS][RDS] Add dimension fields for TSDB support #6079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
6 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kaiyan-sheng
approved these changes
May 16, 2023
| @@ -51,6 +57,7 @@ | |||
| description: | | |||
| Contains the name of the compute and memory capacity class of the DB instance. | |||
| - name: db_instance.identifier | |||
| dimension: true | |||
There was a problem hiding this comment.
db_instance.identifier (should be the same as DBInstanceIdentifier)
so it is not always the same as DBInstanceIdentifier?
There was a problem hiding this comment.
The permissions required to access those parameters are different, so the user can have only one of them set. That's why I decided to set the two parameters as dimensions @tetianakravchenko
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
|
Package aws - 1.38.0 containing this change is available at https://epr.elastic.co/search?package=aws |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Add dimensions. Signed-off-by: constanca-m <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add dimension fields to RDS datastream.
Details
Fields set as dimension:
DBInstanceIdentifier, unique perregionandaccount(both dimensions as well).DBClusterIdentifierand, therefore,Roleas it can be more than one per cluster identifier.EngineNameis the only non-ecs dimension for some documents with metrics related to it.DatabaseClassandSourceRegionfor the same reason asEngineName.db_instance.identifier(should be the same asDBInstanceIdentifier)There is no change in the number of documents after enabling TSDB:
Checklist
changelog.ymlfile.How to test this PR locally
Refer to #6078
Related issues