Skip to content

[TSDB] [postgresql] Add dimensions to Statement datastream #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Mar 14, 2023

Type of change
Please label this PR with one of the following labels, depending on the scope of your change:

  • Enhancement

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner March 14, 2023 13:28
@agithomas agithomas mentioned this pull request Mar 14, 2023
22 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-27T05:14:34.488+0000

  • Duration: 18 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 2.853
Classes 100.0% (4/4) 💚 2.853
Methods 93.333% (28/30) 👍 1.032
Lines 97.041% (164/169) 👍 5.249
Conditionals 100.0% (0/0) 💚

@agithomas agithomas force-pushed the issue-5429-postgresql-tsdb-ds-statement branch from 694766c to f97a414 Compare March 14, 2023 14:03
@agithomas agithomas force-pushed the issue-5429-postgresql-tsdb-ds-statement branch from f97a414 to 4bb1e3e Compare March 14, 2023 14:08
@agithomas agithomas changed the title Issue 5429 postgresql tsdb ds statement [TSDB] [postgresql] Add dimensions to Statement datastream Mar 15, 2023
@botelastic
Copy link

botelastic bot commented Apr 14, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 14, 2023
@botelastic botelastic bot removed the Stalled label May 11, 2023
@botelastic
Copy link

botelastic bot commented Jun 10, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 10, 2023
@agithomas agithomas requested a review from a team as a code owner June 15, 2023 06:15
@botelastic botelastic bot removed the Stalled label Jun 15, 2023
@elasticmachine
Copy link

💔 Build Failed

Failed CI Steps

History

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 5e7b61f into elastic:main Jun 27, 2023
@elasticmachine
Copy link

Package postgresql - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=postgresql

@agithomas agithomas deleted the issue-5429-postgresql-tsdb-ds-statement branch February 12, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants