[Azure Metrics] Fix CassandraConnectionClosures metric configuration #5447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
tdancheva
approved these changes
Mar 7, 2023
|
Package azure_metrics - 1.0.14 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
4 tasks
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 20, 2023
…lastic#5447) * Move CassandraConnectionClosures metrics The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true.
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 21, 2023
…lastic#5447) * Move CassandraConnectionClosures metrics The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move the
CassandraConnectionClosuresmetric name from the always-available list of metrics to the Cassandra-focused list of metrics.Metric names that are not always available should be listed in a section marked with the ignore_unsupported setting set to
true.The integration works if the subscription has at least one Cassandra cluster available but fails otherwise.
Checklist
changelog.ymlfile.Related issues