Skip to content

[cisco_umbrella] Update to v8 format proxy logs #5446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 20, 2023
Merged

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Mar 6, 2023

What does this PR do?

Added Isolate Action, File Action, Warn Status fields required to consume v8 Proxy logs:
Link to documentation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner March 6, 2023 11:21
@elasticmachine
Copy link

elasticmachine commented Mar 6, 2023

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-17T09:58:21.476+0000

  • Duration: 3 min 49 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/integrations.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/LaZyDK return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/LaZyDK : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/LaZyDK : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds jamiehynds added Integration:cisco_umbrella Cisco Umbrella enhancement New feature or request labels Mar 6, 2023
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 17, 2023

@efd6 Can you test this one? It is simpler than the other Umbrella pull.

@efd6
Copy link
Contributor

efd6 commented Mar 17, 2023

/test

@LaZyDK LaZyDK closed this Mar 17, 2023
@LaZyDK LaZyDK deleted the patch-1 branch March 17, 2023 10:26
@elasticmachine
Copy link

elasticmachine commented Mar 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T21:33:53.577+0000

  • Duration: 13 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@LaZyDK LaZyDK restored the patch-1 branch March 17, 2023 10:33
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 17, 2023

My mistake.

@LaZyDK LaZyDK reopened this Mar 17, 2023
@efd6
Copy link
Contributor

efd6 commented Mar 17, 2023

/test

@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 94.444% (17/18)
Lines 93.151% (340/365)
Conditionals 100.0% (0/0) 💚

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The new pattern appears backward compatible.

@andrewkroh andrewkroh merged commit ca75fb5 into elastic:main Mar 20, 2023
@elasticmachine
Copy link

Package cisco_umbrella - 1.6.2 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

@LaZyDK LaZyDK deleted the patch-1 branch March 21, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cisco_umbrella Cisco Umbrella
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants