Skip to content

set default endpoint in aws to empty string #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

aspacca
Copy link
Contributor

@aspacca aspacca commented Aug 31, 2022

Bug

What does this PR do?

Apply an hotfix for elastic/beats#32888 directly in the aws integration package.
Proper fix downstream will be addressed in elastic/beats#32921

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Aug 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-31T08:37:30.705+0000

  • Duration: 37 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 185
Skipped 2
Total 187

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 31, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (16/16) 💚
Files 95.833% (23/24) 👎 -1.512
Classes 95.833% (23/24) 👎 -1.512
Methods 87.302% (275/315) 👎 -2.573
Lines 95.387% (8167/8562) 👍 4.653
Conditionals 100.0% (0/0) 💚

@tommyers-elastic
Copy link
Contributor

thanks for doing this @aspacca !

small nit: the changelog description could be more informative.. we're not really 'fixing' the default endpoint

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - could this have any impact on existing installations at all?

@aspacca aspacca requested a review from a team as a code owner August 31, 2022 08:37
@aspacca
Copy link
Contributor Author

aspacca commented Aug 31, 2022

could this have any impact on existing installations at all?

fips will be disabled with this workaround, until we will merge elastic/beats#32921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants