-
Notifications
You must be signed in to change notification settings - Fork 474
[Fortinet] Deprecate original integration & change logfile to filestream #3819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fortinet] Deprecate original integration & change logfile to filestream #3819
Conversation
packages/fortinet_forticlient/data_stream/log/agent/stream/filestream.yml.hbs
Outdated
Show resolved
Hide resolved
packages/fortinet_forticlient/data_stream/log/agent/stream/filestream.yml.hbs
Outdated
Show resolved
Hide resolved
/test |
🌐 Coverage report
|
@efd6 comments resolved. |
/test |
7107817
to
67985c0
Compare
/test |
1 similar comment
/test |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing from log
to filestream
will cause problems for users because they will lose their existing state. Much of this is discussed in #2518. I think we should hold off on this change given the packages are GA. We'll cover making the change with #2518.
So I think the filestream changes should be reverted.
@andrewkroh Will do. |
82e087d
to
ad51d5f
Compare
ad51d5f
to
994c676
Compare
GTG |
What does this PR do?
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots