Add ECS metricset and fix various visualizations

[legoguy1000]

What does this PR do?

Adds a new datastream for ECS metrics and fixes several visualizations that have invalid fields

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

• Closes [AWS] Dashboards are using wrong field names #3703

Screenshots

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-07-27T14:26:03.558+0000

• Duration: 36 min 59 sec

Test stats 🧪

Test	Results
Failed	0
Passed	334
Skipped	0
Total	334

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[kaiyan-sheng]

/test

[kaiyan-sheng]

Thank you so much for adding this and also fixing the dashboards 😄 Could you add a sample_event.json file for the new datastream? TIA!!

[legoguy1000]

I looked but there wasn't one in the original Metricbeat module.

…

On Mon, Jul 25, 2022 at 2:51 PM kaiyan-sheng ***@***.***> wrote: ***@***.**** commented on this pull request. Thank you so much for adding this and also fixing the dashboards 😄 Could you add a sample_event.json file for the new datastream? TIA!! — Reply to this email directly, view it on GitHub <#3799 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADEEL4A37JZNBR47BSJWPP3VV3V35ANCNFSM54IVP4DQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (11/11)	💚
Files	91.667% (11/12)	👎 -5.454
Classes	91.667% (11/12)	👎 -5.454
Methods	82.464% (174/211)	👎 -6.768
Lines	92.894% (2157/2322)	👍 2.302
Conditionals	100.0% (0/0)	💚

[kaiyan-sheng]

@legoguy1000 We usually run the new datastream locally and copy-paste an event from ES into sample_event.json to show what the event collected by this data stream look like. For example: https://github.com/elastic/integrations/blob/main/packages/aws/data_stream/ec2_metrics/sample_event.json

[legoguy1000]

I can "fake" one but i don't have access to an ECS cluster at this time to generate an event

[zmoog]

Hey @legoguy1000, I hope you don't mind: I installed the integration on my local stack and grabbed a new event from a test cluster.

[legoguy1000]

Teamwork makes the dream work

[kaiyan-sheng]

/test

[legoguy1000]

Thats a copy and paste error. I thought I removed that.

…

On Tue, Jul 26, 2022 at 2:57 PM kaiyan-sheng ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/aws/manifest.yml <#3799 (comment)>: > + title: Amazon ECS + description: Collect metrics for Amazon Elastic Container Service with Elastic Agent + data_streams: + - ecs_metrics + inputs: + - type: aws/metrics + title: Collect ECS metrics + description: Collecting ECS metrics using AWS CloudWatch + input_group: metrics + icons: + - src: /img/logo_ecs.svg + title: AWS EC2 logo + size: 32x32 + type: image/svg+xml + screenshots: + - src: /img/metricbeat-aws-ec2-overview.png I dont think the ec2 dashboard would work for ecs. They are using different field names. — Reply to this email directly, view it on GitHub <#3799 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADEEL4BEI5LRVVGUMSXJL43VWA7KJANCNFSM54IVP4DQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[legoguy1000]

@kaiyan-sheng Resolved the comments.

[kaiyan-sheng]

/test