Skip to content

Compress screenshots in AWS package #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Compress screenshots in AWS package #2767

merged 3 commits into from
Mar 7, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 4, 2022

What does this PR do?

This PR is to compress all screenshots in AWS package to reduce the overall size.
The command I used is:

kaiyansheng@KaiyanMacBookPro:~/go/src/github.com/elastic/integrations/packages/aws/img (compress_dashboards)$ pngquant --ext .png --force *.png

pngquant can be installed with: brew install pngquant

Before:

-rw-r--r--   1 kaiyansheng  staff   393K Oct 13 10:19 filebeat-aws-cloudtrail.png
-rw-r--r--   1 kaiyansheng  staff   1.1M Oct 13 10:19 filebeat-aws-elb-overview.png
-rw-r--r--   1 kaiyansheng  staff   188K Oct 13 10:19 filebeat-aws-s3access-overview.png
-rw-r--r--   1 kaiyansheng  staff   2.5M Oct 13 10:19 filebeat-aws-vpcflow-overview.png
-rw-r--r--   1 kaiyansheng  staff   382K Oct 13 10:19 metricbeat-aws-billing-overview.png
-rw-r--r--   1 kaiyansheng  staff   257K Oct 13 10:19 metricbeat-aws-dynamodb-overview.png
-rw-r--r--   1 kaiyansheng  staff   1.1M Oct 13 10:19 metricbeat-aws-ebs-overview.png
-rw-r--r--   1 kaiyansheng  staff   598K Oct 13 10:19 metricbeat-aws-ec2-overview.png
-rw-r--r--   1 kaiyansheng  staff   597K Oct 13 10:19 metricbeat-aws-elb-overview.png
-rw-r--r--   1 kaiyansheng  staff   496K Oct 13 10:19 metricbeat-aws-lambda-overview.png
-rw-r--r--   1 kaiyansheng  staff   789K Oct 13 10:19 metricbeat-aws-overview.png
-rw-r--r--   1 kaiyansheng  staff   1.5M Oct 13 10:19 metricbeat-aws-rds-overview.png
-rw-r--r--   1 kaiyansheng  staff   329K Oct 13 10:19 metricbeat-aws-s3-overview.png
-rw-r--r--   1 kaiyansheng  staff   717K Oct 13 10:19 metricbeat-aws-sns-overview.png
-rw-r--r--   1 kaiyansheng  staff   347K Oct 13 10:19 metricbeat-aws-sqs-overview.png
-rw-r--r--   1 kaiyansheng  staff   557K Oct 13 10:19 metricbeat-aws-usage-overview.png
-rw-r--r--   1 kaiyansheng  staff   657K Nov 11 08:11 metricbeat-aws-s3-storage-lens-overview.png
-rw-r--r--   1 kaiyansheng  staff   604K Dec 13 14:02 filebeat-aws-firewall-alerts.png
-rw-r--r--   1 kaiyansheng  staff   673K Dec 13 14:02 filebeat-aws-firewall-flows.png
-rw-r--r--   1 kaiyansheng  staff   509K Dec 13 14:02 filebeat-aws-firewall-overview.png
-rw-r--r--   1 kaiyansheng  staff   422K Dec 13 14:02 metricbeat-aws-firewall-overview.png

After:

-rw-r--r--   1 kaiyansheng  staff   136K Mar  3 21:09 filebeat-aws-cloudtrail.png
-rw-r--r--   1 kaiyansheng  staff   401K Mar  3 21:09 filebeat-aws-elb-overview.png
-rw-r--r--   1 kaiyansheng  staff   169K Mar  3 21:09 filebeat-aws-firewall-alerts.png
-rw-r--r--   1 kaiyansheng  staff   186K Mar  3 21:09 filebeat-aws-firewall-flows.png
-rw-r--r--   1 kaiyansheng  staff   152K Mar  3 21:09 filebeat-aws-firewall-overview.png
-rw-r--r--   1 kaiyansheng  staff    55K Mar  3 21:09 filebeat-aws-s3access-overview.png
-rw-r--r--   1 kaiyansheng  staff   743K Mar  3 21:09 filebeat-aws-vpcflow-overview.png
-rw-r--r--   1 kaiyansheng  staff   101K Mar  3 21:09 metricbeat-aws-billing-overview.png
-rw-r--r--   1 kaiyansheng  staff    77K Mar  3 21:09 metricbeat-aws-dynamodb-overview.png
-rw-r--r--   1 kaiyansheng  staff   318K Mar  3 21:09 metricbeat-aws-ebs-overview.png
-rw-r--r--   1 kaiyansheng  staff   160K Mar  3 21:09 metricbeat-aws-ec2-overview.png
-rw-r--r--   1 kaiyansheng  staff   156K Mar  3 21:09 metricbeat-aws-elb-overview.png
-rw-r--r--   1 kaiyansheng  staff   125K Mar  3 21:09 metricbeat-aws-firewall-overview.png
-rw-r--r--   1 kaiyansheng  staff   144K Mar  3 21:09 metricbeat-aws-lambda-overview.png
-rw-r--r--   1 kaiyansheng  staff   214K Mar  3 21:09 metricbeat-aws-overview.png
-rw-r--r--   1 kaiyansheng  staff   356K Mar  3 21:09 metricbeat-aws-rds-overview.png
-rw-r--r--   1 kaiyansheng  staff   102K Mar  3 21:09 metricbeat-aws-s3-overview.png
-rw-r--r--   1 kaiyansheng  staff   164K Mar  3 21:09 metricbeat-aws-s3-storage-lens-overview.png
-rw-r--r--   1 kaiyansheng  staff   165K Mar  3 21:09 metricbeat-aws-sns-overview.png
-rw-r--r--   1 kaiyansheng  staff    88K Mar  3 21:09 metricbeat-aws-sqs-overview.png
-rw-r--r--   1 kaiyansheng  staff   148K Mar  3 21:09 metricbeat-aws-usage-overview.png

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner March 4, 2022 04:14
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 4, 2022
@kaiyan-sheng kaiyan-sheng requested a review from mtojek March 4, 2022 04:17
@andrewkroh
Copy link
Member

What command did you use in case I wanted to replicate this?

@elasticmachine
Copy link

elasticmachine commented Mar 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-04T15:21:24.389+0000

  • Duration: 34 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 327
Skipped 0
Total 327

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit-pick. Thanks for fixing this!

@kaiyan-sheng
Copy link
Contributor Author

What command did you use in case I wanted to replicate this?

@andrewkroh pngquant --ext .png --force *.png is the one I used. Let me add it in the PR description.

@kaiyan-sheng kaiyan-sheng merged commit 02e39e8 into elastic:main Mar 7, 2022
@kaiyan-sheng kaiyan-sheng deleted the compress_dashboards branch March 7, 2022 15:15
zmoog added a commit to zmoog/integrations that referenced this pull request Apr 12, 2022
Effective and easy to apply using `pngquant --ext .png --force *.png`.

Refs: elastic#2767
zmoog added a commit that referenced this pull request Apr 13, 2022
* Add files imported from Beats

I used https://github.com/elastic/integrations/blob/main/docs/import_from_beats.md

* Update metadata and remove logs

We decided the initial release will only include metrics

For porting from Metricbeat we usually start from beta and 0.1.0

* Add cloudformation template

* Disable Container Insights

* Add missing field mappings in the Metricbeat module

* Compress screenshots

Effective and easy to apply using `pngquant --ext .png --force *.png`.

Refs: #2767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants