Skip to content

[iptables] Add journald input support iptables #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 19, 2022
Merged

[iptables] Add journald input support iptables #2525

merged 4 commits into from
Jan 19, 2022

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jan 13, 2022

What does this PR do?

  • Add journald input support.
  • Format MAC addresses.
  • Set event.created.
  • Remove redundant event.ingested.
  • Transition from experimental to beta.
  • Add system test for journald input.
  • Bump stack requirement to 7.16 to get journald input.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh changed the title Add journald input support iptables [iptables] Add journald input support iptables Jan 13, 2022
@elasticmachine
Copy link

elasticmachine commented Jan 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-13T14:34:52.265+0000

  • Duration: 17 min 31 sec

  • Commit: b518f7d

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@@ -76,7 +76,7 @@
"zone": "lan"
}
},
"@timestamp": "2021-10-10T07:25:12.000Z",
"@timestamp": "2022-10-10T07:25:12.000Z",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are living in the future. Should the date parser attempt to make the date the last date that matches the log line as an attempt at sanity rather than the date of the current year that matches the log line or is this not a concern?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the behavior of all the date processor implementations in our stack AFAIK.

There is no shortage of ways things can go wrong when you don't have a year in your timestamps. If you look in the logstash-filter-date repo you'll find some discussion.

- Add journald input support.
- Format MAC addresses.
- Set event.created.
- Remove redundant event.ingested.
- Transition from experimental to beta.
- Add system test for journald.
@@ -76,7 +76,7 @@
"zone": "lan"
}
},
"@timestamp": "2021-10-10T07:25:12.000Z",
"@timestamp": "2022-10-10T07:25:12.000Z",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is the behavior of all the date processor implementations in our stack AFAIK.

There is no shortage of ways things can go wrong when you don't have a year in your timestamps. If you look in the logstash-filter-date repo you'll find some discussion.

@andrewkroh andrewkroh merged commit 1aeb702 into elastic:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:iptables Iptables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants