-
Notifications
You must be signed in to change notification settings - Fork 474
Add cloudwatch input into AWS package for log collection #2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloudwatch input into AWS package for log collection #2323
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@kaiyan-sheng If this is a new raw input package, can you add in a choice in the UI/menu for custom ingest pipeline as well? Similar to the TCP and UDP one. |
Hey @P1llus 👋 This PR is not adding aws-cloudwatch as a new raw input package. It's simply adopting it in logs data streams in the existing aws package. Good to know what I need to pay attention to when adding a new raw input package though! Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would ask @endorama to review that all the titles/descriptions are following the new guidelines
but for that just minor discrepancies on the equivalent files for every data stream
@@ -193,3 +194,107 @@ streams: | |||
type: bool | |||
multi: false | |||
default: false | |||
- input: aws-cloudwatch | |||
template_path: aws-cloudwatch.yml.hbs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the equivalent files for elb_logs
, firewall_logs
and waf
have enabled: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep choose which input to be enabled by default is discussed in #2318.
What does this PR do?
We have
aws-cloudwatch
input in Filebeat as a separate input but never been used in any fileset under AWS module. This PR is to addaws-cloudwatch
as an option for users to ingest logs using AWS package.Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots
For Cloudtrail logs: