-
Notifications
You must be signed in to change notification settings - Fork 474
[AWS] Handle duplicate fields in Network Firewall Logs data stream #13676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Handle duplicate fields in Network Firewall Logs data stream #13676
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
@moxarth-rathod, is there any scenario where this duplicate key could be present in the mapping logic ? If so, we should have test sample data that has such duplicates and see the result. |
@ShourieG Yes, i've already added a test case to fulfil this scenario, in the new test case these fields - |
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package aws - 3.3.1 containing this change is available at https://epr.elastic.co/package/aws/3.3.1/ |
Proposed commit message
Checklist
changelog.yml
file.How to test this PR locally
Related issues