Skip to content

[Corelight] Add data explorer dashboards #12452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sharadcrest
Copy link
Contributor

@sharadcrest sharadcrest commented Jan 24, 2025

Type of change

  • Enhancement

Proposed commit message

  • Add Data Explorer dashboards.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/corelight directory.
  • Run the following command to run tests.

elastic-package test

--- Test results for package: corelight - START ---
╭───────────┬─────────────┬───────────┬────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE   │ DATA STREAM │ TEST TYPE │ TEST NAME                                                          │ RESULT │ TIME ELAPSED │
├───────────┼─────────────┼───────────┼────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ corelight │             │ asset     │ dashboard corelight-023162b6-94da-4d8d-b1f6-de6192356cce is loaded │ PASS   │      1.331µs │
│ corelight │             │ asset     │ dashboard corelight-0cfc8a95-4979-4265-b9ad-91edf63f01a9 is loaded │ PASS   │        189ns │
│ corelight │             │ asset     │ dashboard corelight-2d4dc345-cbbe-4d7a-9203-5ab11c8cb5ba is loaded │ PASS   │        189ns │
│ corelight │             │ asset     │ dashboard corelight-323b0f27-993e-4fee-ae6e-b5977d7cab11 is loaded │ PASS   │        244ns │
│ corelight │             │ asset     │ dashboard corelight-3a4a279f-f238-47de-90ba-f643c5647fde is loaded │ PASS   │        177ns │
│ corelight │             │ asset     │ dashboard corelight-40bbc19b-dd9c-4b43-a88a-e29fc8701902 is loaded │ PASS   │        213ns │
│ corelight │             │ asset     │ dashboard corelight-45197477-c13f-4e52-a5dd-fb4f53564963 is loaded │ PASS   │        241ns │
│ corelight │             │ asset     │ dashboard corelight-58885f47-95e1-4242-a1ee-783de69ace17 is loaded │ PASS   │        241ns │
│ corelight │             │ asset     │ dashboard corelight-65a5fa91-06e4-459b-b4bb-998c85a6cf08 is loaded │ PASS   │        242ns │
│ corelight │             │ asset     │ dashboard corelight-7c0946bc-acd0-4ec3-ab3b-8a92853f4a3b is loaded │ PASS   │        267ns │
│ corelight │             │ asset     │ dashboard corelight-8546a96c-86c9-4edf-9d46-88338d6ac40e is loaded │ PASS   │        276ns │
│ corelight │             │ asset     │ dashboard corelight-8c5f15f7-7063-4228-be54-fb8c20b29caa is loaded │ PASS   │        288ns │
│ corelight │             │ asset     │ dashboard corelight-e4a93cfe-4b1f-44df-ab99-50c74f6f2203 is loaded │ PASS   │        301ns │
│ corelight │             │ asset     │ dashboard corelight-eff0434c-1e27-4c02-959e-9f5d95488efb is loaded │ PASS   │        328ns │
│ corelight │             │ asset     │ dashboard corelight-f1208ffe-d168-46d1-9531-24de523d1bfb is loaded │ PASS   │        320ns │
│ corelight │             │ asset     │ dashboard corelight-f4864774-ed73-4b78-b861-5b8235ec12cf is loaded │ PASS   │        347ns │
│ corelight │             │ asset     │ dashboard corelight-f7da14f0-85db-48e8-a591-1f650af0f618 is loaded │ PASS   │        349ns │
│ corelight │             │ asset     │ dashboard corelight-ff07e65c-2703-4cbe-a45f-3881025352a3 is loaded │ PASS   │        362ns │
│ corelight │             │ asset     │ search corelight-0e9e3c43-9a05-4427-ae03-cd819c418889 is loaded    │ PASS   │        275ns │
│ corelight │             │ asset     │ search corelight-11552ca0-3e4f-4820-ab4a-05e382a371ef is loaded    │ PASS   │        272ns │
│ corelight │             │ asset     │ search corelight-3f297c60-28e0-4914-9ced-787072a95c49 is loaded    │ PASS   │        251ns │
│ corelight │             │ asset     │ search corelight-47793bd6-b227-40eb-b8d6-0089c332c552 is loaded    │ PASS   │        273ns │
│ corelight │             │ asset     │ search corelight-7bc4e6b5-966f-4f20-b1d6-c38040342881 is loaded    │ PASS   │        301ns │
│ corelight │             │ asset     │ search corelight-86b2a063-fb17-4165-8046-843ff5cf33aa is loaded    │ PASS   │        344ns │
│ corelight │             │ asset     │ search corelight-af161fed-c80a-4207-9026-0d3c665efe1a is loaded    │ PASS   │        300ns │
│ corelight │             │ asset     │ search corelight-eb605992-3157-4a95-a654-e2fd650da993 is loaded    │ PASS   │        375ns │
╰───────────┴─────────────┴───────────┴────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: corelight - END   ---
Done

@sharadcrest sharadcrest requested a review from a team as a code owner January 24, 2025 07:16
@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:corelight Corelight (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 24, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh added the enhancement New feature or request label Jan 24, 2025
@sharadcrest sharadcrest marked this pull request as draft January 24, 2025 08:44
@sharadcrest sharadcrest marked this pull request as ready for review January 24, 2025 13:07
@kcreddy
Copy link
Contributor

kcreddy commented Jan 28, 2025

/test

@kcreddy kcreddy added the Crest Contributions from Crest developement team. label Jan 28, 2025
@sharadcrest sharadcrest requested a review from kcreddy January 30, 2025 06:34
@kcreddy
Copy link
Contributor

kcreddy commented Jan 30, 2025

/test

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #21066 succeeded 4751838b81c109f7dcbf53c67a0cb2ad9b1bbdb4

Copy link

@kcreddy kcreddy merged this pull request into elastic:main Jan 30, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package corelight - 0.5.0 containing this change is available at https://epr.elastic.co/package/corelight/0.5.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@sharadcrest sharadcrest deleted the package-corelight-data-explorer-dashboards branch February 10, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crest Contributions from Crest developement team. dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:corelight Corelight (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants