Skip to content

[Linux] Add processors capability to Linux Metrics #10314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

steffenstruebe
Copy link
Contributor

@steffenstruebe steffenstruebe commented Jul 1, 2024

Proposed commit message

Add processors capability to Linux Metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

On each our elastic-agents wie configured some variables to identify our systems in the local elastic-agent.yml:

providers:
  local:
    vars:
      acme_serverid: '12345678-abcd-1234-5678-abcdefgh1234'
      acme_systemid: '87654321-b769-04d5-c851-e8bb5044fb4e'

In the integration settings we consume these variables by following processors:
image

And we can now see our custom ids in the stream to be able to use these for mappings to the rest of our managment tools.
image

Related issues

Screenshots

@steffenstruebe steffenstruebe requested a review from a team as a code owner July 1, 2024 15:19
@steffenstruebe steffenstruebe requested review from belimawr and rdner July 1, 2024 15:19
Copy link

cla-checker-service bot commented Jul 1, 2024

💚 CLA has been signed

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jul 1, 2024
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert
Copy link
Contributor

Hey @steffenstruebe
Thanks for your contribution.
Could you please sign our CLA? We will have someone from our team to review your work after that.

@steffenstruebe steffenstruebe requested a review from belimawr July 1, 2024 16:04
@steffenstruebe steffenstruebe requested a review from belimawr July 2, 2024 16:41
@pierrehilbert
Copy link
Contributor

/test

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @rdner I'll be on PTO soon, can you keep an eye on this PR and make sure it gets merged?

@belimawr
Copy link
Contributor

buildkite test this

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
51.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires tests, I doubt that in the current form it actually works correctly because of the YAML indentation.

@andrewkroh andrewkroh added the Integration:linux Linux Metrics label Jul 19, 2024
@steffenstruebe steffenstruebe requested a review from rdner July 29, 2024 13:41
@rdner rdner merged commit 1284b90 into elastic:main Aug 1, 2024
4 of 5 checks passed
@steffenstruebe steffenstruebe deleted the master branch August 1, 2024 12:42
@elasticmachine
Copy link

Package linux - 0.6.10 containing this change is available at https://epr.elastic.co/search?package=linux

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Add processors capability to Linux Metrics
Fix predefined processors.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Add processors capability to Linux Metrics
Fix predefined processors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:linux Linux Metrics Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants