Skip to content

object_type: keyword #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2023
Merged

object_type: keyword #443

merged 2 commits into from
Oct 10, 2023

Conversation

pzl
Copy link
Member

@pzl pzl commented Oct 10, 2023

Change Summary

for any field marked type: object, it must have the accompanying setting object_type per package-spec.

This sets all of our objects to keyword.

Sample values

N/A

Sample document:

N/A

Release Target

8.12

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)
  • [] If this is a metadata change, I also updated both transform destination schemas to match
    ^^ ????

For Transform changes:

  • [ ] The new transform successfully starts in Kibana
  • [ ] The corresponding transform destination schema was updated if necessary

@pzl pzl requested a review from a team as a code owner October 10, 2023 18:52
@pzl pzl requested review from gergoabraham and parkiino October 10, 2023 18:52
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T19:12:14.617+0000

  • Duration: 7 min 18 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@pzl pzl merged commit cf54cde into main Oct 10, 2023
@pzl pzl deleted the object_type branch October 10, 2023 19:35
@@ -4,6 +4,7 @@
group: 3
short: Fields describing a stack frame.
type: object
object_type: keyword
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create a dynamic mapping for call_stack.* that maps any matching properties a keyword. If you are not expecting properties beyond what is already explicitly mapped, then I would recommend setting type: group and eliminating object_type.

I think all of the cases here where the a non-leaf field was changed to a dynamic mapping should be changed to group. Then the resulting index template would not change, and the package would be following package-spec.

@pzl pzl mentioned this pull request Dec 12, 2023
4 tasks
@elasticmachine
Copy link
Contributor

Package endpoint - 8.13.0 containing this change is available at https://epr.elastic.co/search?package=endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants